Re: renaming XUL Box layout methods
"L. David Baron" <[email protected]>
| Newsgroups | gmane.comp.mozilla.devel.layout |
|---|---|
| Message-ID | <[email protected]> |
On Wednesday 2014-02-05 09:32 +1100, Cameron McCormack wrote:
> L. David Baron wrote:
> >There are a number of XUL Box layout methods that were moved to
> >nsIFrame. In a previous discussion about names, we came to the
> >conclusion that renaming these to have "XUL" in the name would
> >reduce confusion, especially in cases where there is an analogous
> >non-XUL method also on nsIFrame.
> >
> >So I propose renaming the following methods:
>
> Making it obvious they're XUL layout things makes sense to me.
> Although why XULIsCollapsed but IsXULHorizontal?
Yeah, should probably be IsXULCollapsed.
> Also is it possible to push any of these methods down to nsBox/nsBoxFrame?
Maybe, but I suspect not easily (at least for many of them). It's
certainly a lot easier to rename them.
-David
--
𝄞 L. David Baron http://dbaron.org/ 𝄂
𝄢 Mozilla https://www.mozilla.org/ 𝄂
Before I built a wall I'd ask to know
What I was walling in or walling out,
And to whom I was like to give offense.
- Robert Frost, Mending Wall (1914)
_______________________________________________
dev-tech-layout mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-tech-layout
signature.asc
(application/pgp-signature, 836 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJS8WyXAAoJEO/hYSUPhPwhV58P/RqmGQECSWtVh/n7XSuu/CUv X/owfE55I6DNmqXAhFAO7re+p7cJ02P/dbu3NBOtJpDYzib1ESiXgJ2SEGLi6jzy SLyWC4LdDmt5DZW8HdbttOGdU7gOCUVw4K6eI/9z+0KvJ8FDF0izA1H80dbZAVAi f6di11BZ2HNrd2w7SNVNj24mpo0wkClaZeup8NAPWf+qCE++DcGLssA9Itv6Rg6d y210/61Kg9VujVI2PaXJBvp0/pxNcR9WfOm5Q17B0djO5MR2BsAxnAFcoC/Evg9x ZcK0kQwCM/0yZ78oSlomggTprySqfH1RBR0v0k3jm+HPUivK1WOzkOMT7QfPqYaD f3h4RJhxR1efyCnamZTeeCHodLJn+gw/o86XcF6BhrOFJuvLPUS9lB+r7BAnXm19 NB1fkZS2OxZQ89yvlf/k8p4MjMaW+01ldrQPoPzj7fxrXsx6xgstXSJWfIOvGA6B ZwMq1pHeQNk5KvYSTaDxgN07TwHSfS8yN/jS3D4UjZ5le1zLu7dHCb6kT5KdAF+h 5rA/SZ+RGlPFOlkjpSzFNB7SCa34f0u9uYTrXJGxtXtXTJ8ivBS3odFIPJgeToqU tWBS9Ssi9jbhdl/iOj3m9BdNBm5suRivs1GJyhYmTzk6usU5dalnwDwt5pHzY+xx BZt52eqCxLLWt+Gx500y =cL5J -----END PGP SIGNATURE-----