Re: using enum classes for enumerated CSS property values in nsStyleConsts.h

On Wednesday 2015-11-11 17:29 +1100, Xidorn Quan wrote:
> On Wed, Nov 11, 2015 at 5:07 PM, L. David Baron <[email protected]> wrote:
> > 2. Casts
> > ========
> >
> > Does anybody see a good way to eliminate the casts I needed to use
> > in the main patch (described in the patch header)?
> 
> We can probably make them templates?

How?

> One more thing may need to be done before more conversion comes: we
> need a typesafe way to declare bitmasks which we are using for several
> properties. I filed bug 1217241 for something similiar several weeks
> ago.

I think mfbt/TypedEnumBits.h already does this.

-David

-- 
𝄞   L. David Baron                         http://dbaron.org/   𝄂
𝄢   Mozilla                          https://www.mozilla.org/   𝄂
             Before I built a wall I'd ask to know
             What I was walling in or walling out,
             And to whom I was like to give offense.
               - Robert Frost, Mending Wall (1914)

_______________________________________________
dev-tech-layout mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-tech-layout

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWQuLBAAoJEO/hYSUPhPwhwx0QAIh94zj+KMwohgLaMiuAb5ef
mcsajDYQ3trXynq8j4gqBDmQMIV9sBj/TRilJW5z7q0EbihOLvjKyeZHZb9JRZb6
Z6n/+f4UFfg3aiO6muSg0Of0rg0Cq90HX0w7jX7tZmTP0SsjX1W0KE+39XyV6jb+
2579wakwIVz3e1KoS+l8Na83kAtXA7VZwxVhzJxS95OYbLoek5k0KcL5H+bhtoS8
Idx9QE7FCnEkqtIAkdBOAmDN1TItnK+Ed+OeBr6nhyBtxmhLk5pq1x3KkboIf2wb
Yi3FZk6d7QKkVVup/nXDhBNarloKwS4X9lxrTP/r54mm6oRolR5BGBNG2dlKoPwx
yccn/OB/KEEMNG+I/KBlL6a0os5W0Cssj1uIoeo/1kG5U4UGmhddXZDPBHpxvF0B
r24ruZNNxADj++DPXB0wlqvt0w0SOuOvYtvUAsGGvIAWc3ACFaaE9VgOjEEaTsua
xOZqVD+5h4KbyvjhXwgs0xwIGPMKioOW/GPaxc8fPKWdiZUhc6lTcV8Q3o6Ctr0F
nPq0sLp9z0eIV69SlAK+qcNBYWyv2OwFY4jLtoZz6FaDdb+hMYayoP42dmLM1MWy
u/mlKXDY8yyWh8gcRME7nZxO7ot686lBvzx51T7UixFJQDnB5ggVdeypefVAt4+E
OEU5eTpJUffMGevIycvc
=boS1
-----END PGP SIGNATURE-----