Re: Intent to Ship: Display Cutout & CSS Environment Variables
Becca Hughes <[email protected]> Fri, 22 Jun 2018 11:44:25 -0700
| Newsgroups | gmane.comp.web.blink.devel,gmane.comp.mozilla.devel.layout |
|---|---|
| Message-ID | <CAFeLsELqSpuQMQZzE90q-KUHa3KdXw+FTAUXtZPcPyhTsmN11g@mail.gmail.com> |
On Fri, Jun 22, 2018 at 12:47 AM, Rune Lillesveen <[email protected]> wrote: > On Fri, Jun 22, 2018 at 5:54 AM <[email protected]> wrote: > >> + Tab >> >> This focus of this launch is Display Cutout and we want to launch part of >> CSS env() to provide backwards compatability in terms of what Safari has >> already shipped for the iPhone X. >> > > As others have mentioned, proper wpt tests is a requirement here. That > will make you discover short-comings in the spec as well as interop with > Safari. > The pending CL <https://chromium-review.googlesource.com/c/chromium/src/+/1111023> has been updated with more comprehensive WPT tests. > > The full spec for CSS env() has a lot more functionality that is still >> being worked out and that is out of scope for this 'lite' launch of env(). >> > > In terms of a list of all the variable names there is an issue here that >> is working on defining a list: https://github.com/w3c/csswg- >> drafts/issues/2630 >> > > The CSSWG resolved on four values and edits to be made to CSS Variables > Level 2[1]. Do we have a resolution overriding that to put it in a separate > spec? > > I would not be comfortable shipping this without having these four values > put in a spec with a description of what they are. > I am not sure about the resolution, I will let @Tab answer that one. I added a pull request to add them to the spec: https://github.com/w3c/csswg-drafts/pull/2807 > > [1]https://github.com/w3c/csswg-drafts/issues/1693#issuecomment-330909067 > > -- > Rune Lillesveen > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFeLsELqSpuQMQZzE90q-KUHa3KdXw%2BFTAUXtZPcPyhTsmN11g%40mail.gmail.com.