Re: Separate module for User-Agent header (was Re: Proposal: we add new bugzilla component for webRTC stuff?)
Christian Biesinger <[email protected]>
| Newsgroups | gmane.comp.mozilla.devel.netlib |
|---|---|
| Message-ID | <[email protected]> |
On 2/28/2012 15:41, Brian Smith wrote: > Christian Biesinger wrote: >> Yeah, we don't store all request headers. We store a hash of the >> cookie header, and we store all headers that were specified in Vary. > > Couldn't/shouldn't we store a hash of all the headers that were specified in Vary too, instead of storing their values? Maybe we could even combine it with the cookie hash. This would be more space-efficient. That sounds reasonable. Really the code looks like it does because we originally we didn't support Vary: Cookie (for privacy reasons) and then we added support for it using the hashing. Hashing them all together does sound like a good enhancement. FYI, the code is at http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp#3106 (and also http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp#1604) -christian