Re: checks against FD_SETSIZE in _PR_MD_PR_POLL() function (w32poll.c)

Wan-Teh Chang <[email protected]> Mon, 17 Nov 2008 15:51:13 -0800
Newsgroups gmane.comp.mozilla.devel.nspr
Message-ID <[email protected]>
On Mon, Nov 17, 2008 at 3:10 PM, Aleksey Sanin <[email protected]> wrote:
> Hi Wan-Tech,
>
> Thanks for the answer! Yeah, I figured this but the problem is that
> in this particular case (win32) we perform the check *after* we finish
> fd_set manipulations. Not during this check. I believe this check should
> be moved up into the "for" loop above it and ">" replaced with ">=".

Yes, you're right.  We should be performing this check right before
the FD_SET calls.  I filed a bug report with the patch you described:
https://bugzilla.mozilla.org/show_bug.cgi?id=465435

Thanks,
Wan-Teh