Re: Problem with spaces in path name

Wan-Teh Chang wrote:
> On Tue, Jan 13, 2009 at 10:13 AM, Jon Leighton <[email protected]> wrote:
>> I'm having a problem building NPSR in Windows XP when the path name contains
>> spaces.  Changing the path to one without spaces solves the problem, but I
>> need to be able to use paths with spaces.  The path below contains
>> "Documents and Settings", which is causing the problem seen in the output
>> below.  I'm using MozillaBuild 1.3.  Thank you for any help.
>>
>> - Jon
>>
>>
>> $ make
>> cd config; make -j1 export
>> make[1]: Entering directory `/c/Documents and Settings/leighton/develo
>> pment/firefox/source/tcp/3.0.5/config_test/nspr_test/config'
>> cl -Fonow.obj -c      -W3 -nologo -GF -Gy -Od -MD -Z7   -UNDEBUG -DDEB
>> UG_leighton -UWINNT  -DDEBUG=1 -DXP_PC=1 -DWIN32=1 -D_DEBUG=1 -DWIN95=
>> 1 -D_PR_GLOBAL_THREADS_ONLY=1 -D_X86_=1  -DFORCE_PR_LOG   /c/Documents
>> and Settings/leighton/development/firefox/source/tcp/3.0.5/config_test
>> /nsprpub/config/now.c
>> cl : Command line warning D9024 : unrecognized source file type 'c:/Do
>> cuments', object file assumed
>> cl : Command line warning D9027 : source file 'c:/Documents' ignored
>> cl : Command line warning D9024 : unrecognized source file type 'and',
>> object file assumed
>> cl : Command line warning D9027 : source file 'and' ignored
>> now.c
>> c1 : fatal error C1083: Cannot open source file: 'Settings/leighton/de
>> velopment/firefox/source/tcp/3.0.5/config_test/nsprpub/config/now.c':
>> No such file or directory
>> make[1]: *** [now.obj] Error 2
>> make[1]: Leaving directory `/c/Documents and Settings/leighton/develop
>> ment/firefox/source/tcp/3.0.5/config_test/nspr_test/config'
>> make: *** [export] Error
>>
>> $
> 
> Thanks for the bug report.  I can reproduce this bug.  I
> filed a bug report and attached a patch to it:
> https://bugzilla.mozilla.org/show_bug.cgi?id=473413
> 
> Please give the patch a try.
> 
> Wan-Teh

I wasn't able to directly apply your patch because I am using a slightly 
older version of NSPR.  I applied the changes manually and still had a 
problem.  I then looked at rules.mk and noticed the following lines 
shortly following your changes:

   ifeq ($(NS_USE_GCC)_$(OS_ARCH),_WINNT)
   	$(CC) -Fo$@ -c $(CFLAGS) $(call abspath,$<)
   else

I added the appropriate quotes to $(call abspath,$<) per you patch and 
the build went smoothly.  Thank you for your quick response!

- Jon