Re: Problem with spaces in path name

Wan-Teh Chang wrote:
> On Tue, Jan 13, 2009 at 12:25 PM, Jon Leighton <[email protected]> wrote:
>>> Thanks for the bug report.  I can reproduce this bug.  I
>>> filed a bug report and attached a patch to it:
>>> https://bugzilla.mozilla.org/show_bug.cgi?id=473413
>>>
>>> Please give the patch a try.
>>>
>>> Wan-Teh
>> I wasn't able to directly apply your patch because I am using a slightly
>> older version of NSPR.  I applied the changes manually and still had a
>> problem.  I then looked at rules.mk and noticed the following lines shortly
>> following your changes:
>>
>>  ifeq ($(NS_USE_GCC)_$(OS_ARCH),_WINNT)
>>        $(CC) -Fo$@ -c $(CFLAGS) $(call abspath,$<)
>>  else
>>
>> I added the appropriate quotes to $(call abspath,$<) per you patch and the
>> build went smoothly.  Thank you for your quick response!
> 
> I believe that you manually applied my patch incorrectly.
> You may have changed the "ifdef NEED_ABSOLUTE_PATH"
> parts.
> 
> Please run "cvs diff -u8" in your source tree to generate
> a patch and attach it to the bug report.  I'd like to make
> sure I added quotes to all the necessary places.  Thanks.
> 
> Wan-Teh

I've attached the "cvs diff -u8" output to the bug report.  As near as I 
can tell I did not modify the "ifdef NEED_ABSOLUTE_PATH" parts, but I 
may be misreading the code.

- Jon