request for patch testers..

Robert Story <[email protected]> Thu, 3 Nov 2011 11:19:12 -0400
Newsgroups gmane.comp.mozilla.devel.nspr
Organization SPARTA
Message-ID <[email protected]>
--===============0468491351==
Content-Type: multipart/signed; micalg=PGP-SHA1;
 boundary="Sig_/jR1jDh_morx2ZyTeHOM8q=Q"; protocol="application/pgp-signature"

--Sig_/jR1jDh_morx2ZyTeHOM8q=Q
Content-Type: multipart/mixed; boundary="MP_/8+l_c0LOXG_Hl8ApbyrZQYQ"

--MP_/8+l_c0LOXG_Hl8ApbyrZQYQ
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi,

I recently submitted a patch to fix getaddrinfo detection in prnetdb.c.
I've only tested on Linux x86, but I think this issue would affect
anyone on a system where _PR_INET6_PROBE and _PR_HAVE_GETADDRINFO are
defined, which includes almost everyone..

nsprpub/pr/include/md/_osf1.h:71:#define _PR_INET6_PROBE
nsprpub/pr/include/md/_linux.h:297:#define _PR_INET6_PROBE
nsprpub/pr/include/md/_netbsd.h:94:#define _PR_INET6_PROBE
nsprpub/pr/include/md/_openbsd.h:83:#define _PR_INET6_PROBE
nsprpub/pr/include/md/_solaris.h:100:#define _PR_INET6_PROBE
nsprpub/pr/include/md/_bsdi.h:76:#define _PR_INET6_PROBE
nsprpub/pr/include/md/_darwin.h:104:#define _PR_INET6_PROBE
nsprpub/pr/include/md/_freebsd.h:105:#define _PR_INET6_PROBE
nsprpub/pr/include/md/_hpux.h:112:#define _PR_INET6_PROBE
nsprpub/pr/include/md/_win95.h:68:#define _PR_INET6_PROBE
nsprpub/pr/include/md/_winnt.h:81:#define _PR_INET6_PROBE

I've attached 2 patches I'd like help testing. One is simply to debug
which function you system is using:

- apply nspr-fix-getaddrinfo-detection-printf.patch
- rebuild nspr
- run 'make getai' in $OBJDIR/nsprpub/pr/tests/
- run $OBJDIR/nsprpub/pr/tests/getai www.cnn.com

You'll probably see:

   using pr_GetAddrInfoByNameFB as fallback
   www.cnn.com
   157.166.226.25
   157.166.226.26
   157.166.255.18
   157.166.255.19

The second patch provides the actual fix:

- apply nspr-fix-getaddrinfo-detection.patch
- rebuild nspr
- rm $OBJDIR/nsprpub/pr/tests/getai
- run 'make getai' in $OBJDIR/nsprpub/pr/tests/
- run $OBJDIR/nsprpub/pr/tests/getai www.cnn.com

And hopefully you'll see:

   using system getaddrinfo
   www.cnn.com
   157.166.226.25
   157.166.226.26
   157.166.255.18
   157.166.255.19

These patches are against the current mozilla-central code, which
should be pretty close to nspr 4.9.0.

I'd appreciate it if anyone on a non-Linux system could try this and
report back:

- os version
- nspr versin
- did first patch report you system was using getaddrinfo or
  pr_GetAddrInfoByNameFB?
  - if it reported pr_GetAddrInfoByNameFB,
    - did the second patch (the fix) compile ok?
    - did it report using system getaddrinfo after the patch?

You can either report back on the mailing list, mail me privately, or
comment on the bug report, which is
	https://bugzilla.mozilla.org/show_bug.cgi?id=3D699055

Thanks!

--
Senior Software Engineer
SPARTA (dba Cobham Analytic Solutions)

--MP_/8+l_c0LOXG_Hl8ApbyrZQYQ--

--Sig_/jR1jDh_morx2ZyTeHOM8q=Q
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)

iEYEARECAAYFAk6ysPAACgkQ7/fVLLY1mnjoRQCfcu/Ll2pqnp2pWCIJuPTFsPQl
8CAAnjukQ4ptkV/DgxHoqIoUIQp5H6N/
=Tnot
-----END PGP SIGNATURE-----

--Sig_/jR1jDh_morx2ZyTeHOM8q=Q--

--===============0468491351==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
dev-tech-nspr mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-tech-nspr

--===============0468491351==--