Re: Firefox 38.8.0 Beta 7 released
Dmitriy Kuminov <[email protected]>
| Newsgroups | gmane.comp.mozilla.devel.os2 |
|---|---|
| Message-ID | <[email protected]> |
On 2016-06-01 05:33:28 +0000, Dave Yeo said: > The options that you pass to configure, I assume that you added > something like --with-system-nspr and --with-system-nss. Yes this is what I now do. > Ideally they > should be in a mozconfig as configure will load options from it. > Perhaps even added to browser/config/mozconfigs so that anyone running > make -f client.mk or python mach build will end up with a working > browser. Not sure how much work this would take. I get your idea. The thing is that in our workflow such build details live in RPM .spec files so there is no need to store them in the app repo. But since there is no .spec for firefox yet, you basically don't have access to them. Except that you have them in the Wiki (just updated it with my latest set of switches used to build 38.8.0): https://github.com/bitwiseworks/mozilla-os2/wiki/Developers I will consider looking at client.mk again but I personally don't like yet another level between me and makefiles. > Fixes to Firefox.exe, maybe anything under browser and definitely > anything under browser/app should be considered for the other apps. > Yesterday I added your fixes for commit > ec3cf36722a29f11616c454ebd9c4653e7b5b603 (Report error code and faulty > module name on XUL.DLL load error) to nsMailApp.cpp and nsSuiteApp.cpp Okay we should indeed share it across apps. Too pity Mozilla has somewhat ill source code organization in this regard causing code duplication and multiple maintenance... > > I try to keep up on following progress on Github but all weekend Github > didn't load here and this happens quite often. I see. I don't experience anything like that here. -- Kind regards, Dmitriy Kuminov CPO of bww bitwise works GmbH