Re: The future of commit access policy for core Firefox

Kartikaya Gupta <[email protected]> Fri, 10 Mar 2017 13:00:45 -0500
Newsgroups gmane.comp.mozilla.devel.seamonkey
Message-ID <CAHyWLgn3vM4FwzOZQt4A44FjbpsWvYL8tpooJcH2rO-HiHkXWg@mail.gmail.com>
On Fri, Mar 10, 2017 at 12:49 PM, Mike Connor <[email protected]> wrote:
> To expand a bit on that last point: if we can trust core/known developers
> to competently make necessary changes prior to checkin, we should also be
> able to expect them to fix most/all of those issues *before* they submit
> those patches for review.

Not necessarily, because oftentimes those issues are specific to the
reviewer's preferences and the area of code being touched, which the
patch author may not be totally familiar with.

> Assuming we can make significant progress on all of those challenges, and
> the net reviewer overhead is about the same, are there other reasons we
> wouldn't want to move to a much stricter review process?

I think the burden of proof is on anybody claiming they can do this
without increasing net reviewer overhead. Without actually showing
that can be done, this whole line of reasoning is kind of moot.

Cheers,
kats