Re: The future of commit access policy for core Firefox

Ehsan Akhgari <[email protected]> Fri, 10 Mar 2017 21:06:01 -0500
Newsgroups gmane.comp.mozilla.devel.seamonkey
Message-ID <CANTur_6K-Rk7+3Tc4ih6OuJYT99mxFJGVxo1B31bt+B+eh4qwA@mail.gmail.com>
On Fri, Mar 10, 2017 at 8:17 PM, Cameron McCormack <[email protected]> wrote:

> On Sat, Mar 11, 2017, at 09:02 AM, Nicholas Nethercote wrote:
> > I'm surprised that Servo and Rust haven't come up yet, because they do
> > already have a model much like the one suggested -- landing approval must
> > come from an authorized reviewer.
>
> In Servo, reviewers sometimes do "r+ with changes" by saying "delegate+"
> in the PR, which tells the landing bot that the PR submitter can mark
> the patch as reviewed themselves (even after pushing some updates).
>

OK, something like this would address the issue of reviewers refraining
from asking for nits.  But the detail of the implementation matter here...

-- 
Ehsan