Re: The future of commit access policy for core Firefox

On Sun, Mar 12, 2017 at 8:44 PM, Daniel Veditz <[email protected]> wrote:
> Hypothetically, an evil person could take a "r+ with nits" and then
> check in the patch with bad code that was never seen by another human
> and which may not get noticed. When we put autoland into the mix this
> essentially gives L3 commit access to anyone who can put together a
> helpful "almost right" patch.

I don't see how that's the case. To actually land something on
Autoland, you need to have L3 commit access. So, if this hypothetical
evil person does not themselves have L3 commit access, after getting
an "r+ with nits" and adding malicious code along with the nits, it's
still their reviewer who needs to submit to Autoland, and thus has the
opportunity to review their changes before submitting them.

Cheers,
Botond