Re: The future of commit access policy for core Firefox
Nicholas Nethercote <[email protected]> Tue, 14 Mar 2017 11:52:41 +1100
| Newsgroups | gmane.comp.mozilla.devel.seamonkey |
|---|---|
| Message-ID | <CAEXw-ADChy831evqFNCoCgtEy7iE==CWaL7ta7qSo-mPYiwsHg@mail.gmail.com> |
On Tue, Mar 14, 2017 at 7:24 AM, Lawrence Mandel <[email protected]> wrote: > > One issue with r+ with nits that we ran into last year is that the > resulting patch/diff is often committed directly to the repo and not > uploaded back to Bugzilla or MozReview. This makes it difficult to audit > the changes to the repo. I always look at the hg commit link rather than posted patches, precisely because I know that's exactly what landed. Even if the patch author doesn't explicitly change anything after getting review, rebasing can still change the patch. Nick