Re: Feedback on XML content sink plans

In article <[email protected]>,
 Boris Zbarsky <[email protected]> wrote:

> Henri Sivonen wrote:
> > I wrote about my plans on incrementalizing the XML content sink (bug 
> > 18333):
> > http://hsivonen.iki.fi/kesakoodi/content-sink/
> > 
> > I would appreciate a sanity check. Does it look right?

> What happens if the error is inside a <script> tag?  Do we "partially render" 
> the script?   I feel we should not.

Probably not. The HTML side has a malformed flag.

> What happens with XSLT exactly?  That is, how is a well-formedness error in a 
> document that has an XSLT stylesheet handled?
> 
>  > Don¹t be incremental with innerHTML.
>  > Don¹t be incremental with XHR.
> 
> Not an issue; that stuff isn't being rendered anyway.  So either behavior is 
> ok 
> here; just do whatever is easiest.

Great.

>  > Don¹t be incremental with DOM LS.
> 
> I don't believe we implement that, do we?

What's nsLoadSaveContentSink for?

>  > Don¹t be incremental with XBL when loading a binding.
> 
> Again, either behavior is fine here; do whatever is easiest.

Excellent.

>  > I¹d rather not factor anything out of SinkContext.
> 
> That's all the code that keeps track of what's been flushed, etc.  Is the 
> plan 
> to just fork it all, then?

Perhaps forking it isn't a good idea after all. Would it be smart to 
move SinkContext into a separate .cpp/h file pair and inherit an 
nsHTMLSinkContext and an nsXMLSinkContext so that the XML side would 
only have one context?

-- 
Henri Sivonen
[email protected]
http://hsivonen.iki.fi/