Re: Feedback on XML content sink plans
Boris Zbarsky <[email protected]> Mon, 12 Jun 2006 14:00:43 -0500
| Newsgroups | gmane.comp.mozilla.devel.xml |
|---|---|
| Message-ID | <[email protected]> |
Henri Sivonen wrote: > Second, spreading the use of SinkContext would make it > more entrenched and would probably raise the barrier of getting the > eight-year-old HTML parser/sink combo replaced with a line-by-line > implementation of the HTML5 parsing spec. And the more I read the code, > the more I'd like to see an HTML5-compliant rewrite. As long as we're sure the HTML5 thing won't break any sites... ;) I do think that it would be nice if a lot of the magic that happens in the HTML content sink would go away. > Third, the code of the XML content sink is a lot cleaner to begin with than the code of the > HTML content sink, so it would be a shame to make the XML side more > convoluted just to share code that isn't particularly shareable. That I agree with. > I think I'll roll my tree back and return to my plan of picking lines of code > to imitate on the XML side. OK. If it's not easy to factor out, this sounds like the way to go, with comments added to both impls about fixing the other if the one is fixed and so on. -Boris