DummyParserRequest and XML
Henri Sivonen <[email protected]> Fri, 30 Jun 2006 14:54:20 +0300
| Newsgroups | gmane.comp.mozilla.devel.xml |
|---|---|
| Message-ID | <[email protected]> |
I got incremental XML loading (bug 18333) going. However, the comments in the HTML content sink said that a DummyParserRequest is needed in order to keep end events firing on interrupting the parser, so I hoisted DummyParserRequest to nsContentSink.cpp and used it on the XML side as well. This broke the incremental loading. I thought I had neglected to prepare the wall clock timing stuff properly before letting expat parse a buffer. I fixed that but incrementality remained broken. I took the DummyParserRequest out. Incrementality worked again. It turns out that DummyParserRequest is on its way out anyway: https://bugzilla.mozilla.org/show_bug.cgi?id=294115 Is the fix for https://bugzilla.mozilla.org/show_bug.cgi?id=293818 already taking care of everything on the XML side that DummyParserRequest takes care of on the HTML side? Which events are at stake? OnLoad? Others? How should I proceed investigating whether I break something? -- Henri Sivonen [email protected] http://hsivonen.iki.fi/