Re: Windows and .url files and nsILocalFileWin
Darin Fisher <[email protected]> Wed, 19 Nov 2003 14:10:26 -0800
| Newsgroups | gmane.comp.mozilla.devel.netlib,gmane.comp.mozilla.devel.xpcom |
|---|---|
| Message-ID | <[email protected]> |
Boris Zbarsky wrote: >Christian Biesinger wrote: > > >>That requires code to get from a .url file to the URL it links to. >> >> > >I assume that's not covered by the existing symlink stuff on nsIFile? > > > >>string instead of nsIURI because this is xpcom (=> no necko), and >>because the current callers want a string. >> >>So. this is my proposal. Any comments on this? >> >> > >Seems OK. > >-Boris > > Use |AUTF8String| instead of |string|. URL strings are best represented as UTF-8. This is important since xpconnect needs to know what to do if it encounters a byte with the 8-th bit set. ResolveShortcut might be confusing here since the Win32 nsLocalFile implemenation already thinks of files that end with .lnk as shortcuts. Is there maybe a better name for files that end with .url? If not, then maybe we need to at least choose a more distinct name here to avoid confusion in our code. I asked christian to send this email out because I'm not sure that nsILocalFileWin is the best solution here. It works, but maybe there is a better solution. I'd prefer to avoid introducing a new service, and since we have nsILocalFileMac, adding nsILocalFileWin seems reasonable. Darin