Re: Adding a dll

Daniel Veditz wrote:

> Jonathan Watt wrote:
> 
> 
>>>GdiPlus.dll is a MS redistributable file, right? If so you'd want to add it
>>>to the following places:
>>>
>>>http://lxr.mozilla.org/mozilla/source/xpinstall/packager/windows/makexpi.pl#82
>>>http://lxr.mozilla.org/mozilla/source/xpinstall/packager/win_gre/makexpi.pl#82
>>>http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/installer/makexpi.pl#69
>>>
>>>-Dan Veditz
>>
>>That's great, thanks Dan! Yes gdiplus.dll is an MS dedistributable. I'll 
>>give that a go and hopefully it will work this time. :)
>>
>>I have subsequently thought of another problem. The distributed version 
>>of that DLL should only be used by Mozilla when run on win2k and below 
>>since they don't have a version of gdiplus.dll. WinXP has a copy of this 
>>file and Mozilla should use it instead (apparently it will cause 
>>problems if it doesn't). Does the installer provide a way to detect the 
>>version of Windows and only install the file if it should be installed?
> 
> 
> Oops, forgot an important point. For a normal Mozilla library developers
> only need to make sure it gets into the install archive using the package
> lists and the rest just works.

What does that mean? I still make the changes at the five locations you 
have mentioned?


> These OS redistributables need to be handled a bit differently as you note.
> The makexpi.pl change will put the file into the installer archives, but you
> need script changes to get it back out correctly. For Mozilla and Firefox
> you'll need to copy what was done with msvcrt.dll around here:
> 
> http://lxr.mozilla.org/mozilla/source/xpinstall/packager/windows/xpcom.jst#52
> http://lxr.mozilla.org/mozilla/source/browser/installer/windows/xpcom.jst#52
> 
> -Dan Veditz

The code at those locations puts the libraries into a windows system 
folder. I must put gdiplus.dll alongside mozilla.exe according to 
microsoft. I guess if I look around I can figure out how to do this, but 
feel free to tell me if you know offhand. ;)

Thanks again Dan,

Jonathan