Re: Native Unicode converter
Doug Turner <[email protected]> Tue, 04 Apr 2006 11:43:33 -0700
| Newsgroups | gmane.comp.mozilla.internationalization |
|---|---|
| Message-ID | <[email protected]> |
So, in the bug https://bugzilla.mozilla.org/show_bug.cgi?id=332646 Jungshik Shin points out a few problems with this approach. The test cases also mentioned in the bug fail (a few of them do). I have no idea how bad this is. As far as the UTF-16/1200 entry... I generated the table by looking at what unicode converters we support then discovering the code page that IE uses. I noticed that a table like this (charset name -> codepage) didn't exist, so I just dropped it in this code. (it is a linear search, we can optimize later). Regards, Doug Doug Turner wrote: > Setting followups to i18n. Lets figure out if this will work for > general windows users there. > > Doug > > Jean-Marc Desperrier wrote: >> Doug Turner wrote: >>> I wrote a native Unicode converter for windows ce which also works on >>> Windows 32. This allows us to remove alot of code+data from firefox >>> (on ARM i saved .67MB). This might be something we could enable on >>> the trunk since we have dropped Windows 98 support. If you have time, >>> i would love for you to evaluate it. To create a build, just add this >>> like to your mozconfig: >>> >>> ac_add_options --enable-native-uconv >>> >>> The code for this converter lives here: >>> http://lxr.mozilla.org/mozilla/source/intl/uconv/native/nsWinCEUConvService.cpp >> >> >> >> I got a fast look at the code. >> >> I wonder what part exactly makes you worry for 98 support ? Is that >> about CP_UTF8 ? (referenced in your patch by it's numeric value 65001) >> >> Then it's supported from 98 upward, in fact should also be available >> on 95 when you first install Internet Explorer on it, so as far as >> that part is concernet even 2.0 could take it. >> >> I was a bit surprised by the UTF-16/1200 entry in the map, and in fact >> you should remove it. If actually used, it won't work. >> Kaplan happens to explain that here : >> http://blogs.msdn.com/michkap/archive/2005/08/01/446475.aspx >> >> Cross-posted to mozilla.dev.i18n