Re: Using new jemalloc features in our code

Benjamin Smedberg <[email protected]> Mon, 07 Jul 2008 14:07:50 -0400
Newsgroups gmane.comp.mozilla.license
Message-ID <[email protected]>
Sergey Yanovich wrote:

> However, let's don't pretend the original proposal was equally so. If 
> all Mozilla code uses NS_Alloc/Free, this and system malloc/free 
> constitute *at least* two allocator/deallocator pair. To avoid crashes 
> caused by wrong deallocator, I see to fast track solutions:
> 
> 1) carefully match every alloc/dealloc call pairs and equally tests 
> versions with both patched CRT and double heap.
> 
> 2) drop support for the non-patched version.
> 
> Everyone would agree that #2 is times easier, if not the only doable 
> solution. I am still having doubts #1 is feasible. All major developers 
> work with patched CRT. After certain period of time, hard-to-detect 

* This discussion is off-topic for mozilla.legal.
* Most of our hackers use the express version of MSVC and therefore do not 
use the patched CRT. Claiming "All major developers..." is just nonsense.

--BDS