Re: Small problem in buildPlayList()

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jari Korhonen wrote:
> Hello all,
> 
> First, a big thanks for all of you who have contributed to 
> mplayerplug-in. Your work has made browsing in Linux much more enjoyable.
> 
> Then, my 2 cents: As a big Nightwish (a finnish hard rock/metal band, 
> www.nightwish.com) fan, I tried to listen to a local radio interview of 
> band leader Tuomas Holopainen at
> http://lotta.yle.fi/rswebjsu.nsf/sivut/juttutori2004?opendocument&pageid=ContentEC55C
> 
> For some reason the link "kuuntele" (listen) would not play.
> 
> I compiled last nights' source with debugging on and found the culprit 
> in function buildPlayList(). The realaudio file in question has contents:
> 
>  rtsp://ra.yle.fi/pohjoiskarjalanradio/realaudio/audio_out/p-kar2007092001370.ra
> --stop--  
>  pnm://ra.yle.fi/pohjoiskarjalanradio/realaudio/audio_out/p-kar2007092001370.ra
> 
> Because both rtsp and pnm lines start with a space, it is enough to fail 
> these compares:
> 
>         // simple playlist usually realmedia file
>         if (strncasecmp(buffer, "rtsp", 4) == 0 && found == 0) {
> 
>         // simple playlist usually realmedia file
>         if (strncasecmp(buffer, "pnm", 3) == 0 && found == 0) {
> 
> Changing these lines to read:
> 
>             // simple playlist usually realmedia file
>             if (memmem(buffer_lower, size, "rtsp", 4) != NULL  && found 
> == 0) {
> 
>             // simple playlist usually realmedia file
>             if (memmem(buffer_lower, size, "pnm", 3) != NULL && found == 
> 0) {
> 
> 
> fixes the problem. Now onto hearing how Nightwish will conquer the world ;-)
> 
> Cheers,
> 
> Jari

I went ahead and implemented this patch and committed it to cvs. I still
think the playlist itself is kinda broken so I guess this is a
workaround for it.

Kevin


- --
Get my public GnuPG key from
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x7D0BD5D1
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Remi - http://enigmail.mozdev.org

iD8DBQFG88nz6w2kMH0L1dERAtJZAJ0V+mzkswVOyRJqy1FBSbw5fV6I5ACfY4CE
n0Yi1ripWKlGJ6d4NVhdWmk=
=V1xZ
-----END PGP SIGNATURE-----

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/