Re: [PATCH] fix for apple/trailers crash

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/02/2009 12:04 PM, Avi Rozen wrote:
> Hi,
> 
> Since the beginning of last month I can't access any movie trailer on
> apple.com - I get a segmentation fault as soon as the link to the .mov
> file is accessed.
> 
> For reference: I'm running Debian/testing, Iceweasel 3.0.9 (unbranded
> firefox), Debian packaged v 3.55  of mplayer plugin, and mplayer
> 1.0.rc2svn20090412 (packaged by debian-multimedia.org).
> 
> This seems to have already been reported as Ubuntu bug #360222 [1], and
> Arch Linux bug #14155 [2].
> 
> I get the following typical output when running from a terminal:
> 
> ADDED URL: harrypotterhalfbloodprince-tlr4b_h640w.mov
> code: 42
>  speed -1
> 
> and then the segfault.
> 
> I used this text as a starting point for debugging and luck was on my
> side :-)
> 
> The crash happens at plugin-list.cpp, line 414, during the call to
> memmem. The cause is a typo in the exit condition at line 411 - 'p'
> appears instead of 'buffer' (see attached patch), so that we get to line
> 414 even if there's no next "rmda" (consider lines  348, 418). All line
> numbers refer to the code from the daily snapshot.
> 
> I'm guessing that something must have changed at apple.com to trigger
> this specific code path. In any case, the patched plugin seems to work
> nicely at my end.
> 
> Cheers,
> Avi.
> 
> [1] https://bugs.launchpad.net/bugs/360222
> [2] http://bugs.archlinux.org/task/14155

Avi,

Can you please provide a sample site that I can test with. I'm using
mplayerplug-in from CVS and I don't see any crashes with the Apple
site... I tried "the international" and "17 again" trailers.

Also, have you tried gecko-mediaplayer?

Kevin




- -- 
Get my public GnuPG key from
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x7D0BD5D1
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkn8pPEACgkQ6w2kMH0L1dFHbQCeMy5cyqnxax/sljJBZT0ehOIg
IyIAnRF7Wv4lMXp37inU7euvZBh95ueG
=kxry
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
Register Now & Save for Velocity, the Web Performance & Operations 
Conference from O'Reilly Media. Velocity features a full day of 
expert-led, hands-on workshops and two days of sessions from industry 
leaders in dedicated Performance & Operations tracks. Use code vel09scf 
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf