Re: Bug? Information disclosure

Paul Hartman wrote:
> Open a website in a tab, then press control-B to open bookmarks and
> double-click a bookmark to visit the site in the existing active tab.
> The URL of the existing page will be sent to the bookmarked site as
> the referrer. This could be potentially embarrassing or politically
> dangerous. :P
> 
> Is it a MultiZilla bug or seamonkey? I reported a very similar bug in
> MultiZilla a few years ago, which HJ fixed immediately, so I suspect
> it's maybe happening again in MultiZilla somewhere.
> 
> I'm using:
> Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.17) Gecko/20080924
> MultiZilla/1.8.3.5i SeaMonkey/1.1.12
> 
> Thanks,
> Paul

Paul,

First, disable MultiZilla and try to reproduce the bug.
BTW how are you testing this?

Let me add some background information, this is how opening bookmarks 
work as in the program flow:

BookmarksCommand.getBrowserTargetFromEvent()
BookmarksCommand.shouldLoadTabInBackground()
BookmarksCommand.shouldOpenInTab()
BookmarksCommand.shouldLoadTabInBackground()
BookmarksCommand.openOneBookmark()
tabbrowser.addTab()
tabbrowser.addOrInsertTab()

Note: I do see this warning in my JS Error Console. You too?

Warning: reference to undefined property 
aEvent.originalTarget.parentNode.parentNode.clickCount
Source File: 
chrome://multiviews/content/bookmarks/bookmarksBindingOverlay.xul
Line: 60

And here's a link to SeaMonkey bookmarks.js file
http://mxr.mozilla.org/seamonkey/source/suite/common/bookmarks/bookmarks.js#536

Which, at first glance, doesn't seem to do anything wrong, but neither 
do we (MultiZilla). I guess I need to investigate this, which I will do 
right now..

/HJ

-- 
I am HJ and I LIVE STRONG.
Supporter of the Lance Armstrong Foundation
http://www.livestrong.org