Re: ARIA cipher addition in NSS - Assertion failure --- NSS_3_28_3_RTM

On Monday, January 15, 2018 at 3:31:33 PM UTC+5, f masood wrote:
> 1. I am adding the ARIA (ciphersuite) in Thunderbird (nss) for TLS establishment[ a research project].
> 
> 2. I am reading the existing ChaCha/Poly and other patches available on the internet for modifying the NSS source code.
> 
> 3. After doing changes in NSS directory files, I am able to compile & build the thunderbird (tb 52.0.0) successfully.
> 
> 4. But when I run the TB.EXE it fails, showing error "Assertion failure: oid->offset == i, at ... ... ... /mozilla/secuirty/nss/lib/util/secoid.c:2082"
> 
> 
> 5. I have added the following lines in the secoid.c file:
> 
> i. #define ARIA_OID 0x2a, 0x83, 0x1a, 0x8c, 0x9a, 0x44, 0x09
> ii.     OD(aria_CBC, SEC_OID_ARIA_CBC,
>        "ARIA-CBC", CKM_ARIA_CBC, INVALID_CERT_EXTENSION),
> iii. CONST_OID aria_CBC[] = { ARIA_OID, 5 };
> 
> 
> 6. What is causing the issue ? How to use / define OID ? 
> 
> Any advice/hint/guidance in this regard would be helpful.

I figured it out myself, the issue was coming because I had placed my CUSTOM cipher in the middle with other ciphers however it should come at the end to match ...