AES-NI for non-GCM ciphers on macOS

[email protected] Mon, 6 Jan 2020 15:15:21 -0800 (PST)

Newsgroups	gmane.comp.mozilla.security
Message-ID	<[email protected]>

It appears AES-NI is not being used on macOS for non-GCM ciphers.  I tested with NSS 3.36 on macOS 10.14.6 but there appears to be no difference with latest NSS.  The hw-support tool provided by NSS indicates all CPU features are available on the test device which has an i7-8559U.

With the linked changes I believe I've gotten macOS working the same as Linux 64-bit for non-GCM ciphers: https://pastebin.com/NprMX8HA.

I'm wondering if there are any issues with this and if there would be any chance of integrating these changes assuming I could clean it up so only macOS is affected.