RE: [Re-Send] CR: Fix the issue that mjpeg thumbnail inavi container can not be displayed correctly

My comments:

@@ -825,6 +825,8 @@
     //printf ("CSourceInput::OnStreamHeader\n");
     IHXBuffer* pMime = NULL;
     pValues->GetPropertyCString("MimeType", pMime);
+    strncpy (thumbPicInfo.mimeType, pMime->GetBuffer(), pMime->GetSize());
+

If pMime->GetSize() > 256, then this will result in a crash, and is
therefore a security flaw. You can correct this by using
SafeStrCpy() in common/runtime/pub/safestring.h. However, you'll
first need to make sure that pMime is NULL-terminated.

Alternatively, you could fix this by not using a fixed-length
buffer for mimeType.

Rest of the changes look good.

Eric
=============================================
Eric Hyche ([email protected])
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: [email protected] 
> [mailto:[email protected]] On 
> Behalf Of Chen, Weian
> Sent: Wednesday, June 25, 2008 9:48 PM
> To: [email protected]
> Subject: [helix-client-dev][Re-Send] CR: Fix the issue that 
> mjpeg thumbnail inavi container can not be displayed correctly
> 
>  
> 
> Please have a review..
> 
>  
> 
> Weian
> 
> ________________________________
> 
> From: Chen, Weian 
> Sent: 2008624 14:05
> To: [email protected]
> Cc: [email protected]
> Subject: [helix-client-dev] CR: Fix the issue that mjpeg 
> thumbnail in avi container can not be displayed correctly
> 
>  
> 
> Synopsis: 
> 
>   Fix the issue that mjpeg thumbnail in avi container can not 
> be displayed correctly.
> 
>  
> 
> Overview: 
> 
>   The color space of decoded stream can be RGB or I420, and 
> we do different color conversion for different format, then 
> solve the mjpeg thumbnail issue, we used to regarding all 
> decoded stream as RGB.
> 
>  
> 
> Files Added:
> 
>   None
> 
>  
> 
> Files Modified:
> 
>   player/hxclientkit/pub/HXClientCallbacks.h
> 
>   player/hxclientkit/src/platform/unix/CHXClientThumbnailUnix.cpp
> 
>   player/kit/dbus-server/pub/hxplayer.h
> 
>   player/kit/dbus-server/src/hxplayer.cpp
> 
>   player/kit/dbus-server/src/helix-dbus-server.cpp
> 
>  
> 
> Image Size and Heap Use impact (Client -Only):
> 
>   Little
> 
>  
> 
> Platforms and Profiles Affected:
> 
>   platform:   linux-2.2-libc6-gcc32-i586
> 
>   profile:     helix-client-all-defines
> 
>  
> 
> Distribution Libraries Affected:
> 
>   <libhxclient.a> <helix-dbus-server.bin>
> 
>  
> 
> Distribution library impact and planned action:
> 
>   <None>
> 
>  
> 
> Platforms and Profiles Build Verified:
> 
>   Set BIF branch   -> hxdbus_3_1_0_atlas
> 
>   Set Target(s)     -> dbus_server_with_video
> 
>   Set Profile       -> helix-client-all-defines
> 
>   System ID       -> linux-2.2-libc6-gcc32-i586
> 
>  
> 
> Branch: 
> 
>   HEAD, hxclient_3_1_0_atlas
> 
>  
> 
> Copyright assignment: <MUST be one of the following statements >
> 
> 2.      Intel has signed and delivered a Joint Copyright Assignment
> 
>            to RealNetworks, and received acknowledgment that the 
> 
>            agreement was received.  
> 
>  
> 
> Files Attached:
> 
>   hxclient_thumbnail_mjpeg.diff
> 
>   dbus_server_thumbnail_mjpeg.diff
> 
>  
> 
> Weian
> 
>  
> 
> 


_______________________________________________
Helix-client-dev mailing list
[email protected]
http://lists.helixcommunity.org/mailman/listinfo/helix-client-dev