Re: [Midplayer-private-dev] Midplayer-private-dev] CN: Add black frame detection in thumbnail, so we can get valid frame(non-blank) form the video stream as the thumbnail.

Hi Weian,

The right branch is atlas_3_1_0.

Thanks,
Rishi.

At 06:58 PM 7/17/2008, Chen, Weian wrote:

>Modified and committed to atlas_3_2_0 and head branch.
>
>Thanks a lot.
>
>Weian
>
>-----Original Message-----
>From: Eric Hyche [mailto:[email protected]]
>Sent: 2008Äê7ÔÂ17ÈÕ 23:14
>To: Chen, Weian; [email protected]
>Cc: [email protected]
>Subject: RE: [Midplayer-private-dev] [helix-client-dev] CR: Add black 
>frame detection in thumbnail, so we can get valid frame(non-blank) form 
>the video stream as the thumbnail.
>
>Weian,
>
>Here are my comments on this change:
>
>+       for (int i = 0; i < width; i++)
>+       {
>+               SAD += src [(pixNumber >> 1) + i];
>+       }
>+       for (int i = 0; i < width; i++)
>+       {
>+               SAD += src [(pixNumber >> 1) + width + i];
>+       }
>
>This doesn't really take the middle two rows of the frame. It takes a 
>partial row, then a full row, then another partial row.
>
>If you really want to middle two rows, then this should be:
>
>      UINT32 ulRowBegin = (height >> 1) * width;
>      for (UINT32 i = 0; i < width * 2; i++)
>      {
>          SAD += src[ulRowBegin + i];
>      }
>
>Similar idea for the RGB24 and RGB32 cases.
>
>Rest looks good.
>
>Eric
>
>=======================================
>Eric Hyche ([email protected])
>Senior Technical Lead
>RealNetworks, Inc.
>
>
> >-----Original Message-----
> >From: [email protected] 
> [mailto:midplayer-private-dev-
> >[email protected]] On Behalf Of Chen, Weian
> >Sent: Thursday, July 17, 2008 4:46 AM
> >To: [email protected]
> >Cc: [email protected]
> >Subject: [Midplayer-private-dev] [helix-client-dev] CR: Add black frame 
> detection in thumbnail, so we
> >can get valid frame(non-blank) form the video stream as the thumbnail.
> >
> >Synopsis:
> >
> >  Add black frame detection support in thumbnail, so we can get valid 
> frame (non-blank) form the video
> >stream as the thumbnail.
> >
> >
> >
> >Overview:
> >
> >   Currently, we always get first key frame of a stream as the 
> thumbnail, and many of these frames are
> >black, so we can't get the needed information. Then we add black frame 
> detection, until we get a valid
> >frame then stop doing thumbnail.
> >
> >
> >
> >Files Added:
> >
> >  None
> >
> >
> >
> >Files Modified:
> >
> >  player/hxclientkit/pub/HXClientCallbacks.h
> >
> >  player/hxclientkit/src/platform/unix/CHXClientThumbnailUnix.cpp
> >
> >  player/kit/dbus-server/pub/hxplayer.h
> >
> >  player/kit/dbus-server/src/hxplayer.cpp
> >
> >  player/kit/dbus-server/src/helix-dbus-server.cpp
> >
> >
> >
> >Image Size and Heap Use impact (Client -Only):
> >
> >  Little
> >
> >
> >
> >Platforms and Profiles Affected:
> >
> >  platform:   linux-2.2-libc6-gcc32-i586
> >
> >  profile:      helix-client-all-defines
> >
> >
> >
> >Distribution Libraries Affected:
> >
> >  <libhxclient.a> <helix-dbus-server.bin>
> >
> >
> >
> >Distribution library impact and planned action:
> >
> >  <None>
> >
> >
> >
> >Platforms and Profiles Build Verified:
> >
> >  Set BIF branch  -> hxdbus_3_1_0_atlas
> >
> >  Set Target(s)     -> dbus_server_with_video
> >
> >  Set Profile        -> helix-client-all-defines
> >
> >  System ID        -> linux-2.2-libc6-gcc32-i586
> >
> >
> >
> >Branch:
> >
> >  HEAD, hxclient_3_1_0_atlas
> >
> >
> >
> >Copyright assignment: <MUST be one of the following statements >
> >
> >2.      Intel has signed and delivered a Joint Copyright Assignment
> >
> >           to RealNetworks, and received acknowledgment that the
> >
> >           agreement was received.
> >
> >
> >
> >Files Attached:
> >
> >  hxclient-nonblank-thumbnail.diff
> >
> >  dbus-nonblank-thumb.diff
> >
> >
> >
> >Weian
> >
> >
>
>
>
>_______________________________________________
>Midplayer-private-dev mailing list
>[email protected]
>http://lists.helixcommunity.org/mailman/listinfo/midplayer-private-dev


Rishi Mathew
Helix Community
RealNetworks, Inc.
[email protected]
http://www.helixcommunity.org
http://www.realnetworks.com/products/support/devsupport.html

_______________________________________________
Helix-client-dev mailing list
[email protected]
http://lists.helixcommunity.org/mailman/listinfo/helix-client-dev