CR: Fix m_ulALSAPeriodSize issue

Synopsis: 

    m_ulALSAPeriodSize is a new variable added to resolve some BT issue,
but there is still some issue after the patch. After carefully code
review, I found we should translate it to Bytes unit.

 

Overview: 

    m_ulALSAPeriodSize is a new variable added to resolve some BT issue,
but there is still some issue after the patch. after carefully code
review, I found we should translate it to Bytes unit.

 

Files Added:

       No file added

Files Modified:

    audio/device/platform/unix/audUnix.cpp

        translate m_ulALSAPeriodSize to be measured by Bytes.

    audio/device/pub/platform/unix/audUnix.h

        add some comment

            

Image Size and Heap Use impact (Client -Only):

    little

Platforms and Profiles Affected:

    platform:   linux-2.2-libc6-gcc32-i586

    profile:    helix-client-all-defines

 

Distribution Libraries Affected:

    <hxmedpleng.so>

Distribution library impact and planned action:

    <None>

Platforms and Profiles Build Verified:

    Set BIF branch  -> hxclient_3_1_0_atlas_restricted

    Set Target(s)   -> player_mid_all_installers (or splay)

    Set Profile     -> helix-client-all-defines

    System ID       -> linux-2.2-libc6-gcc32-i586

Branch: 

    HEAD

Copyright assignment: <MUST be one of the following statements >

   2.      Intel has signed and delivered a Joint Copyright Assignment

           to RealNetworks, and received acknowledgment that the 

           agreement was received. 

Files Attached:

    audio-device-period.diff.txt

 

ZHAO, Halley (Aihua)

Email: [email protected] <mailto:[email protected]> 

Tel: +86(21)61166476

iNet: 8821-6476

SSG/OTC/UMD

_______________________________________________
Helix-client-dev mailing list
[email protected]
http://lists.helixcommunity.org/mailman/listinfo/helix-client-dev

? audio-device-period.diff.txt
Index: platform/unix/audUnix.cpp
===================================================================
RCS file: /cvsroot/audio/device/platform/unix/audUnix.cpp,v
retrieving revision 1.12.2.2.2.2
diff -u -w -r1.12.2.2.2.2 audUnix.cpp
--- platform/unix/audUnix.cpp	16 Jul 2008 13:31:12 -0000	1.12.2.2.2.2
+++ platform/unix/audUnix.cpp	21 Jul 2008 04:19:14 -0000
@@ -360,7 +360,7 @@
     m_wLastError = retCode;
 
 #ifdef HELIX_FEATURE_ALSA_WRITE_PERIOD_SIZE
-	m_ulALSAPeriodSize = _GetPeriodSize();
+	m_ulALSAPeriodSize = _GetPeriodSize() * (m_uSampFrameSize*m_unNumChannels);
 #endif //HELIX_FEATURE_ALSA_WRITE_PERIOD_SIZE
     return m_wLastError;
 }
Index: pub/platform/unix/audUnix.h
===================================================================
RCS file: /cvsroot/audio/device/pub/platform/unix/audUnix.h,v
retrieving revision 1.8.2.1.4.1
diff -u -w -r1.8.2.1.4.1 audUnix.h
--- pub/platform/unix/audUnix.h	10 Jul 2008 09:39:08 -0000	1.8.2.1.4.1
+++ pub/platform/unix/audUnix.h	21 Jul 2008 04:19:14 -0000
@@ -291,7 +291,7 @@
     ULONG32	m_ulSleepTime;
     IHXEvent*	m_pAvailableDataEvent;
 #endif    
-    ULONG32 m_ulALSAPeriodSize;
+    ULONG32 m_ulALSAPeriodSize; // size in Bytes.
 #ifdef HELIX_FEATURE_ALSA_WRITE_PERIOD_SIZE
     CHXSimpleList	m_bufferList;
     UINT32 m_ulByteCount;       /* Number of bytes in the buffer list*/