CR[RESENDING]: Changes in hxclient_3_1_0_atlas.bif for better Fix of Bug 8682

Resending.

---------------------------- Original Message ----------------------------
Subject: CR: Changes in hxclient_3_1_0_atlas.bif for better Fix of Bug 8682
From:    [email protected]
Date:    Tue, September 23, 2008 5:40 pm
To:      [email protected]
--------------------------------------------------------------------------

Project: RealPlayer for Netbook

Synopsis: Changes in hxclient_3_1_0_atlas.bif for better Fix of Bug 8682

Overview:

datatype_dist_wm_video_codec_wmv8 is now also defined in
hxclient_3_1_0_atlas.bif. It was already in
hxclient_3_1_0_atlas_restricted.bif
NOTE: datatype_dist_wm_video_codec_wmv8 module definitions exist in both
hxclient_1_5_0_cayenne.bif and hxclient_1_5_0_cayenne_restricted.bif

Now we are using HELIX_FEATURE_WM macro which will be defined in
hxclient_3_1_0_atlas.bif. As a result, the macro will only be defined if
the module is actually built.

Files Modified:
build/BIF/hxclient_3_1_0_atlas.bif

Image Size and Heap Use impact (Client -Only):
None.

Platforms and Profiles Affected:
Linux

Distribution Libraries Affected:
None.

Distribution library impact and planned action:
None.

Platforms and Profiles Build Verified:
Profile: helix_client_all_defines
Target: linux_realplayer
BIF: realplay_gtk_atlas_restricted

Files Attached:
hxclient_3_1_0_atlas.diff

Thanks,
Deepak Jain

_______________________________________________
Helix-client-dev mailing list
[email protected]
http://lists.helixcommunity.org/mailman/listinfo/helix-client-dev

Index: hxclient_3_1_0_atlas.bif
===================================================================
RCS file: /cvsroot/client/build/BIF/hxclient_3_1_0_atlas.bif,v
retrieving revision 1.65
diff -u -r1.65 hxclient_3_1_0_atlas.bif
--- hxclient_3_1_0_atlas.bif	27 Aug 2008 14:57:52 -0000	1.65
+++ hxclient_3_1_0_atlas.bif	23 Sep 2008 08:58:26 -0000
@@ -3455,8 +3455,20 @@
         </dependlist>
     </module>
 
+    <!-- DATATYPE_DIST_WM_VIDEO_CODEC_WMV8 -->
+    <module id="datatype_dist_wm_video_codec_wmv8" group="core">
+        <attribute id="no_build"/>
+        <sdk name="wmv8_decoderlib" path="C:\Path\To\WPK">
+            This build requires the Windows Media Video 8 Porting Kit. If you are 
+            not a Windows Media Video 8 Porting Kit licensee, then this module will not build.
+        </sdk>
+    </module>
+
     <!-- ALL_WM_PLUGINS -->
     <module id="all_wm_plugins" group="core" type="name_only">
+      <defines>
+          HELIX_FEATURE_WM
+      </defines>
       <dependlist>
           common_log_logsystem
           common_log_logobserverfile