RE: Error causes floating point exception in CAudioOutLinuxAlsa::_SetDeviceConfig()

I think getting your commit access should be no problem. Then you can submit a patch via the patch submission guidelines:

https://common.helixcommunity.org/2005/patch/

I'm copying [email protected] to see about getting you write access.

Eric

=======================================
Eric Hyche ([email protected])
Principal Engineer
RealNetworks, Inc.


>-----Original Message-----
>From: [email protected] [mailto:[email protected]]
>On Behalf Of Nguyen, Khanh V
>Sent: Monday, April 27, 2009 8:43 PM
>To: [email protected]
>Subject: [Helix-client-dev] Error causes floating point exception in
>CAudioOutLinuxAlsa::_SetDeviceConfig()
>
>Hi,
>
>In the CAudioOutLinuxAlsa::_SetDeviceConfig() method, if there's an error before the
>snd_pcm_hw_params_get_period_size(hwparams, &period_size, 0) call, it will skip this call.  When this
>call is skipped, period_size is zero.  When the calculation for start_threshold started, a floating
>point exception is thrown because of a divide-by-zero problem.
>
>
>
>Could someone apply a quick patch for this?  I currently don't have commit access.
>
>
>
>Thanks,
>
>--Khanh