CN: hxplay.cpp

Thanks Greg,

I added a #define at the top, which we'll duplicate in our TLC.  It'll 
be easier than modifying hxresult.h (for instance) and I need to get 
something in tonight's build.


Index: hxplay.cpp
===================================================================
RCS file: /cvsroot/client/core/hxplay.cpp,v
retrieving revision 1.99.2.29.2.1
diff -u -w -r1.99.2.29.2.1 hxplay.cpp
--- hxplay.cpp	22 Oct 2007 21:09:42 -0000	1.99.2.29.2.1
+++ hxplay.cpp	5 May 2009 23:23:18 -0000
@@ -219,7 +219,7 @@
  #define NUM_FORWARD_KEYFRAMES_AHEAD_STR 
"PlaybackVelocity\\NumForwardKeyFramesAhead"
  #define NUM_REVERSE_KEYFRAMES_AHEAD_STR 
"PlaybackVelocity\\NumReverseKeyFramesAhead"
  #define STOP_WHEN_HIT_START_IN_REVERSE 
"PlaybackVelocity\\StopWhenHitStartInReverse"
-
+#define HX_NOTIFY_AUDIO_RESUME              0x52484150
  #define GOTOEXITONERROR(theErr, label)      if (theErr) goto label

  /* Please add any variables to be re-initialized in the ResetPlayer()
@@ -2976,6 +2976,10 @@
  #endif /* #if !defined(HELIX_FEATURE_LOGLEVEL_NONE) */

          theErr = m_pAudioPlayer->Resume();
+
+        HXLOGL3(HXLOG_CORE, "HXPlayer[%p]::CheckForAudioResume(): 
Completed resume", this);
+
+        ActualReport(HXLOG_INFO, HXR_OK, HX_NOTIFY_AUDIO_RESUME, NULL, 
NULL);
      }

      return theErr;


Greg Wright wrote:
> I would probably make a #define for the magic number,
> but looks good for 203Cay.
> 
> --greg.
> 
> 
> Nicholas Hart wrote:
>>
>> synopsis:
>> On Cay203 branch use IHXErrorSink to report an informational message 
>> to the client so it knows when audio playback has resumed.
>>
>> overview:
>> To help us better track how long it takes to begin playing back a 
>> track we need a way for the client core to inform the top-level client 
>> when audio has resumed.  Since the cayenne 203 branch doesn't support 
>> atlas's state machine model and callbacks, using IHXErrorSink with 
>> HXLOG_INFO and a magic number recognized by the client seems like the 
>> cleanest way to provide this notification.  Also adding an HXLOG 
>> statement so we can detect how long it took to resume the audio.
>>
>> branches:
>> hxclient_2_0_3_cayenne
>>
>> files modified:
>> client/core/hxplay.cpp
>>
>> heap/size impact:
>> none
>>
>> builds verified:
>> windows, helix-client-all-defines
>>
>>
>>
>> Index: hxplay.cpp
>> ===================================================================
>> RCS file: /cvsroot/client/core/hxplay.cpp,v
>> retrieving revision 1.99.2.29.2.1
>> diff -u -w -r1.99.2.29.2.1 hxplay.cpp
>> --- hxplay.cpp    22 Oct 2007 21:09:42 -0000    1.99.2.29.2.1
>> +++ hxplay.cpp    5 May 2009 15:53:30 -0000
>> @@ -2976,6 +2976,10 @@
>>  #endif /* #if !defined(HELIX_FEATURE_LOGLEVEL_NONE) */
>>
>>          theErr = m_pAudioPlayer->Resume();
>> +
>> +        HXLOGL3(HXLOG_CORE, "HXPlayer[%p]::CheckForAudioResume(): 
>> Completed resume", this);
>> +
>> +        ActualReport(HXLOG_INFO, HXR_OK, 0x52484150, NULL, NULL);
>>      }
>>
>>      return theErr;
>>
>> _______________________________________________
>> Helix-client-dev mailing list
>> [email protected]
>> http://lists.helixcommunity.org/mailman/listinfo/helix-client-dev
>>
> 
> 
>