Re: [Nokia-private-dev] CR: - Helix HEAD - Added CLSIDs to create instance of classes that implements IHXPlayer and IXVolume interfaces in Phonon backend appframework

Looks good.
--greg.


On Aug 27, 2009, at 12:35 PM, [email protected] wrote:

> "Nokia submits this code under the terms of a commercial  
> contribution agreement with Real Networks, and I am authorized to  
> contribute this code under said agreement."
>
> Modified by: [email protected]
>
> Reviewed by:
>
> Date: 08/26/2009
>
> Project: phonon_backend
>
> ErrorId: N/A
>
> Synopsis: Helix HEAD - Added CLSIDs to create instance of classes  
> that implements IHXPlayer, and IXVolume interfaces in Phonon backend  
> appframework;
>
> Overview: Phonon backend application framework uses class factory to  
> create instance of classes that implements IHXPlayer and IXVolume  
> interfaces. Helix uses the interface ids of the interfaces that  
> represent a class as CLSID. As phonon backend application framework  
> uses its own class factory to create instance of these classess, it  
> won't conflit with helix class factory. Again it hides object  
> instance information from phonon backend. Added class ids  
> CLSID_IHXPlayer and CLIS_IHXVolme to identify phonon common  
> appframework classes CHXPlayerProxy and CHXVolumeProxy.
>
> Files modified: cvsroot\common\include\hxcore.h
>                          cvsroot\common\include\hxausvc.h
>
> Files added: None
>
> Image Size and Heap Use impact: None.
>
> Module Release testing (STIF) : N/A
>
> Test case(s) Added  : No
>
> Memory leak check performed : N/A
>
> Platforms and Profiles Build Verified: helix-client-s60-ng
>
> Platforms and Profiles Functionality verified: armv5, winscw
>
> Branch: HEAD
>
> Index: hxcore.h
> ===================================================================
> RCS file: /cvsroot/common/include/hxcore.h,v
> retrieving revision 1.23
> diff -u -w -r1.23 hxcore.h
> --- hxcore.h   6 Jul 2007 20:43:41 -0000       1.23
> +++ hxcore.h   20 Apr 2009 15:25:40 -0000
> @@ -507,6 +507,7 @@
>
>   #undef  INTERFACE
>   #define INTERFACE   IHXPlayer
> +#define CLSID_IHXPlayer IID_IHXPlayer
>
>   DECLARE_INTERFACE_(IHXPlayer, IUnknown)
> {
>
> Index: hxausvc.h
> ===================================================================
> RCS file: /cvsroot/common/include/hxausvc.h,v
> retrieving revision 1.19
> diff -u -w -r1.19 hxausvc.h
> --- hxausvc.h  6 Jul 2007 20:43:41 -0000       1.19
> +++ hxausvc.h  20 Apr 2009 15:26:51 -0000
> @@ -1023,6 +1023,7 @@
>
>   #undef  INTERFACE
>   #define INTERFACE   IHXVolume
> +#define CLSID_IHXVolume IID_IHXVolume
>
>   DECLARE_INTERFACE_(IHXVolume, IUnknown)
> {
>
>
> _______________________________________________
> Nokia-private-dev mailing list
> [email protected]
> http://lists.helixcommunity.org/mailman/listinfo/nokia-private-dev