[Helix-client-dev] Re: CR/CN: Updated UITS data ID3 Owner Identifier to the correct URL [GMPMetaEditor branch]
Petar Basic <[email protected]> Fri, 15 Jan 2010 13:38:44 +0100
| Newsgroups | gmane.comp.multimedia.helix.devel |
|---|---|
| Message-ID | <[email protected]> |
Forgot the diff file. Attached here. On Fri, Jan 15, 2010 at 1:37 PM, Petar Basic <[email protected]> wrote: > Modified by: pbasic at real.com > Date: 2010/01/15 > Project: GMPMetaEditor (meta3gp.exe) > > Synopsis: > Updated UITS data ID3 Owner Identifier to the correct URL > > Details: > When stored inside the ID3 tag, UITS data must be placed into a PRIV > frame. That PRIV frame should be marked with correct Owner Identifier > to be able to distinguish it from other various PRIV frames. The > correct Owner Identifier to use for UITS is > "mailto:[email protected]". > > Files Modified: > datatype/include/metainfokeys.h > > Platforms and Profiles Affected: > All > > Image Size and Heap Use impact: > None > > Platforms and Profiles Build Verified: > system id: win32-i386-vc7, sunos-5.10-sparc-studio11 > profile: helix-client-all-defines > > Platforms and Profiles Functionality Verified: > x86 Windows XP SP2 > Sparc SunOS 5.10 > > Branch: > GMPMetaEditor > > Copyright assignment: > I am a RealNetworks employee or contractor. > _______________________________________________ Helix-client-dev mailing list [email protected] http://lists.helixcommunity.org/mailman/listinfo/helix-client-dev
datatype_include.diff
(application/octet-stream, 2.5 KB)
Index: metainfokeys.h
===================================================================
RCS file: /cvsroot/datatype/include/metainfokeys.h,v
retrieving revision 1.6
diff -d -H -w -U20 -r1.6 metainfokeys.h
--- metainfokeys.h 9 Nov 2009 19:38:57 -0000 1.6
+++ metainfokeys.h 15 Jan 2010 12:28:20 -0000
@@ -30,42 +30,41 @@
* http://www.helixcommunity.org/content/tck
*
* Contributor(s):
*
* ***** END LICENSE BLOCK ***** */
#ifndef _METAINFOKEYS_H_
#define _METAINFOKEYS_H_
typedef enum
{
METAINFO_SET_GENERIC = 0x00000001,
METAINFO_SET_3GPP_SPECIFIC = 0x00000010,
METAINFO_SET_3GPP_ALL = METAINFO_SET_GENERIC | METAINFO_SET_3GPP_SPECIFIC,
METAINFO_SET_ITUNES_SPECIFIC = 0x00000100,
METAINFO_SET_ITUNES_ALL = METAINFO_SET_GENERIC | METAINFO_SET_ITUNES_SPECIFIC,
METAINFO_SET_ALL = METAINFO_SET_GENERIC | METAINFO_SET_3GPP_SPECIFIC | METAINFO_SET_ITUNES_SPECIFIC
} METAINFO_SET;
-// XXXPB TODO: update value according to UITS spec
-#define _META_INFO_UITS_OWNER_IDENTIFIER "http://www.uits-data.org/"
+#define _META_INFO_UITS_OWNER_IDENTIFIER "mailto:[email protected]"
#define _META_INFO_BUFFER_PROPERTY_ID3_TAG_VERSION_MINOR 4
// Generic set
#define _GENERIC_META_INFO_TITLE_KEY "Title"
#define _GENERIC_META_INFO_COMPOSER_KEY "Author"
#define _GENERIC_META_INFO_COPYRIGHT_KEY "Copyright"
#define _GENERIC_META_INFO_DESCRIPTION_KEY "Description"
#define _GENERIC_META_INFO_ARTIST_KEY "Performer"
#define _GENERIC_META_INFO_GENRE_KEY "Genre"
#define _GENERIC_META_INFO_ALBUM_KEY "AlbumTitle"
#define _GENERIC_META_INFO_TRACK_NUMBER_KEY "TrackNumber"
#define _GENERIC_META_INFO_RECORDING_YEAR_KEY "RecordingYear"
#define _GENERIC_META_INFO_PICTURE_COUNT_KEY "APICDataCount"
#define _GENERIC_META_INFO_PICTURE_KEY "APICData%d"
#define _GENERIC_META_INFO_UITS_KEY "UITSData"
// iTunes aliases for Generic set, for use in file-format/file-writer
#define _ITUNES_META_INFO_TITLE_KEY _GENERIC_META_INFO_TITLE_KEY
#define _ITUNES_META_INFO_COMPOSER_KEY _GENERIC_META_INFO_COMPOSER_KEY
#define _ITUNES_META_INFO_COPYRIGHT_KEY _GENERIC_META_INFO_COPYRIGHT_KEY