答复: [Helix-client-dev] CR: 259182 - potent ial security exploit

Also committed to 361atlas.

Kinson

-----邮件原件-----
发件人: Charles Chen
发送时间: 2010年4月27日 7:47
收件人: Kinson Liu; Feng (Eric) Liu; Huafeng (Frank) Lan
主题: FW: [Helix-client-dev] CR: 259182 - potential security exploit

Hi Kinson,

CR 259182 fixes a security issue which we should also integrate it to 361Atlas branch. Could you please apply this fix in 361 and send a CN? After you are done, could you please kick start a build and have Eric to regress test the new build?

Thanks,
Charles
________________________________________
From: Tony Seaward
Sent: Monday, April 26, 2010 11:04 AM
To: Charles Chen; Leina Tani
Cc: Xiaodong (Sheldon) Fu
Subject: Re: [Helix-client-dev] CR: 259182 - potential security exploit

This likely is a fix we want to move to all appropriate branches. Sheldon will give an appropriate CR, then I'll have Steve check this into HEAD and 310 for sure. I'll talk with Nokia about them moving it over as well. This only effects gecko decoders, which I believe all the projects you both are working on use it, so we'll leave the sub branch owners responsible for getting this one in.

Tony Seaward
Helix DNA Program Manager
RealNetworks, Inc.
(206) 674-2391

On 4/23/10 3:31 PM, Steve Blanding wrote:
This was a case of trying to delete memory that wasn’t ever allocated.  The cause was uninitialized class variables.
The fix below fixes this problem along with a number of related potential others.

Index: fixpt/decoder/hxwrapper/gecko2decshim.cpp
===================================================================
RCS file: /cvsroot/rarvcode-audio/codec/ra8lbr/fixpt/decoder/hxwrapper/gecko2decshim.cpp,v
retrieving revision 1.4.58.1
diff -u -w -r1.4.58.1 gecko2decshim.cpp
--- fixpt/decoder/hxwrapper/gecko2decshim.cpp           27 Apr 2005 19:26:10 -0000           1.4.58.1
+++ fixpt/decoder/hxwrapper/gecko2decshim.cpp        23 Apr 2010 22:20:17 -0000
@@ -74,7 +74,13 @@
   return HXR_OK ;
 }

-COldGeckoDecoderShim::COldGeckoDecoderShim() {}
+COldGeckoDecoderShim::COldGeckoDecoderShim():
+    mChannels(0),
+    mFrameSamples(0),
+    mFrameBytes(0),
+    mInterleaveBuffer(NULL),
+    codecs(NULL)
+{}
 COldGeckoDecoderShim::~COldGeckoDecoderShim(){}

 HX_RESULT COldGeckoDecoderShim::InitDecoder(int sampleRate, int nChannels, int nFrameBits, BYTE *pOpaqueData, int opaqueDataLength, int &codingDelay)
@@ -152,7 +158,11 @@

 /* the shim for the new codec is rather thin in fact */

-CNewGeckoDecoderShim::CNewGeckoDecoderShim() {}
+CNewGeckoDecoderShim::CNewGeckoDecoderShim():
+    mFrameBits(0),
+    mSamplesPerFrame(0),
+    pCodec(NULL)
+{}
 CNewGeckoDecoderShim::~CNewGeckoDecoderShim(){}

 HX_RESULT CNewGeckoDecoderShim::InitDecoder(int sampleRate, int nChannels, int nFrameBits, BYTE *pOpaqueData, int opaqueDataLength, int &codingDelay)
Index: fltpt/decoder/gecko2decshim.cpp
===================================================================
RCS file: /cvsroot/rarvcode-audio/codec/ra8lbr/fltpt/decoder/gecko2decshim.cpp,v
retrieving revision 1.4.58.1
diff -u -w -r1.4.58.1 gecko2decshim.cpp
--- fltpt/decoder/gecko2decshim.cpp    27 Apr 2005 19:26:36 -0000           1.4.58.1
+++ fltpt/decoder/gecko2decshim.cpp 23 Apr 2010 22:20:17 -0000
@@ -82,7 +82,13 @@
   return HXR_OK ;
 }

-COldGeckoDecoderShim::COldGeckoDecoderShim() {}
+COldGeckoDecoderShim::COldGeckoDecoderShim():
+    mChannels(0),
+    mFrameSamples(0),
+    mFrameBytes(0),
+    mInterleaveBuffer(NULL),
+    codecs(NULL)
+{}
 COldGeckoDecoderShim::~COldGeckoDecoderShim(){}

 HX_RESULT COldGeckoDecoderShim::InitDecoder(int sampleRate, int nChannels, int nFrameBits, BYTE *pOpaqueData, int opaqueDataLength, int &codingDelay)
@@ -184,7 +190,11 @@

 /* the shim for the new codec is rather thin in fact */

-CNewGeckoDecoderShim::CNewGeckoDecoderShim() {}
+CNewGeckoDecoderShim::CNewGeckoDecoderShim():
+    mFrameBits(0),
+    mSamplesPerFrame(0),
+    pCodec(NULL)
+{}
 CNewGeckoDecoderShim::~CNewGeckoDecoderShim(){}

 HX_RESULT CNewGeckoDecoderShim::InitDecoder(int sampleRate, int nChannels, int nFrameBits, BYTE *pOpaqueData, int opaqueDataLength, int &codingDelay)
@@ -219,7 +229,14 @@
 }

 /* multi channel decoder */
-CGeckoMCDecoderShim::CGeckoMCDecoderShim() {}
+CGeckoMCDecoderShim::CGeckoMCDecoderShim():
+    mNumCodecs(0),
+    mTotalBytes(0),
+    mChannelsTotal(0),
+    mSamplesPerFrame(0),
+    mInterleaveBuffer(NULL),
+    codecs(NULL)
+{}
 CGeckoMCDecoderShim::~CGeckoMCDecoderShim(){}

 HX_RESULT CGeckoMCDecoderShim::InitDecoder(int sampleRate, int nChannels, int nFrameBits, BYTE *pOpaqueData, int opaqueDataLength, int &codingDelay)


__________ Information from ESET NOD32 Antivirus, version of virus signature database 5063 (20100426) __________

The message was checked by ESET NOD32 Antivirus.

http://www.eset.com



__________ Information from ESET NOD32 Antivirus, version of virus signature database 5063 (20100426) __________

The message was checked by ESET NOD32 Antivirus.

http://www.eset.com

_______________________________________________
Helix-client-dev mailing list
[email protected]
http://lists.helixcommunity.org/mailman/listinfo/helix-client-dev