[Helix-client-dev] Re: [Nokia-private-dev] RESEND: [client-dev] CR Symbian: Fix coverity check finding in hxaudsec.cpp

ok

On 9/24/2010 8:02 AM, [email protected] wrote:
> Modified by:  [email protected]
> Reviewed by:
> Date: 09/20/2010
> Project: symbian_client_apps
> Synopsis: Using pointer after NULL check
> Overview: Coverity check complains that a pointer is used before NULL check.
> Files Added:
> Files Modified:
> \client\audiosvc\hxaudsec.cpp
> Image Size and Heap Use impact: minor
> Module Release testing :
> Test case(s) Added :
> Memory leak : No
> Platforms and Profiles Build Verified:
> helix-client-s60-52-mmf-mdf-dsp
> Platforms and Profiles Functionality verified: armv5
> Branch: 420Brizo, HEAD.
> Index: hxaudses.cpp
> ===================================================================
> RCS file: /cvsroot/client/audiosvc/hxaudses.cpp,v
> retrieving revision 1.84.2.1.2.2
> diff -u -r1.84.2.1.2.2 hxaudses.cpp
> --- hxaudses.cpp 14 Sep 2010 18:13:37 -0000 1.84.2.1.2.2
> +++ hxaudses.cpp 20 Sep 2010 21:21:02 -0000
> @@ -4749,10 +4749,10 @@
> {
> if (CanStartPowerSave())
> {
> - CHXSimpleList::Iterator lIter = m_pPlayerList->Begin();
> - CHXAudioPlayer* pPlayer = (CHXAudioPlayer*) (*lIter);
> if (m_pPlayerList && m_pPlayerList->GetCount() == 1)
> {
> + CHXSimpleList::Iterator lIter = m_pPlayerList->Begin();
> + CHXAudioPlayer* pPlayer = (CHXAudioPlayer*) (*lIter);
> theErr = pPlayer->StartPowerSave();
> if (theErr == HXR_OK)