Re: [Helix-client-dev] CR:Change to fix bug 15009[swift]:It always crashed when playing the progressive download audio streaming in the second time
Qiang Luo <[email protected]> Wed, 6 Jun 2012 09:44:24 -0700
| Newsgroups | gmane.comp.multimedia.helix.devel |
|---|---|
| Message-ID | <[email protected]> |
--===============0846510601== Content-Type: multipart/alternative; boundary="------------010702000409040100050201" --------------010702000409040100050201 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: quoted-printable Looks good. Qiang On 6/6/2012 2:42 AM, James (Jian) Li wrote: > > Modified by: [email protected] > > Date: 06/05/2012 > > Project: RealPlayer for Android Smartphones > > Synopsis: CR: 14965:[swift][simple core]:it always crashed when=20 > playing the progressive download audio stream in the second time using=20 > the simple core. > > Overview: > > The root cause is that there are several objects can not be released,=20 > their destructor can not be invoked since their ref counts are=20 > notequal to zero, which leads to the second time connection can not be=20 > established. > > Files Added: > > N/A > > File Modified: > > client/simplecore/hxflsrc.cpp > > client/simplecore/hxplay.cpp > > client/simplecore/hxrender.cpp > > client/simplecore/hxstrm.cpp > > datatype/ogg/fileformat/ogg_page_reader.cpp > > player/kit/android/4.0/PlayerDriver.cpp > > Image Size and Heap Use impact (Client -Only): > > None > > Platforms and Profiles Affected: > > Platform: hxclient_3_6_1_atlas > > Profile: helix-client-android-full > > Distribution Libraries Affected: > > None > > Distribution library impact and planned action: > > None > > Platforms and Profiles Build Verified: > > Platform: android-4.0-arm-qsd_8x60 > > Profile: helix-client-android-full > > Platforms and Profiles Functionality verified: > > Platform: android-4.0-arm-qsd_8x60 > > Profile: helix-client-android-full > > Branch: 361atlas > > Copyright assignment: I am a RealNetworks employee. > > Another Comment: > > In the file: client/simplecore/hxbsrc.cpp, the function: DoCleanup()=20 > do nothing, while the function HXSource::Close() release the other=20 > objects, I think that we can release this objects through=20 > HXSource::DoCleanup(), and we can call the HXSource ::DoCleanup() in=20 > the destructor of HXSource, the function HXSource::Close can be=20 > replaced by the HXSource::DoCleanup(), I don=92t know whether it is=20 > suitable. If it is suitable I will modify this file. Could any experts=20 > give me some comments, > > Best Regards > > James Li > > RealNetworks China, Beijing Office > > Tel: 86-10-59542762 > > Address: 18th Floor,Tower B,Pacific Century Place,2A=20 > GongTiBeiLu,Chaoyang District,Beijing, China Post Code: 100027 > --------------010702000409040100050201 Content-Type: text/html; charset="windows-1252" Content-Transfer-Encoding: quoted-printable <html> <head> <meta content=3D"text/html; charset=3Dwindows-1252" http-equiv=3D"Content-Type"> </head> <body bgcolor=3D"#FFFFFF" text=3D"#000000"> Looks good.<br> <br> Qiang<br> <br> On 6/6/2012 2:42 AM, James (Jian) Li wrote: <blockquote cite=3D"mid:[email protected]= om" type=3D"cite"> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dwindows-1252"> <meta name=3D"Generator" content=3D"Microsoft Word 11 (filtered medium)"> <o:smarttagtype namespaceuri=3D"urn:schemas-microsoft-com:office:smarttags" name=3D"place"> <o:smarttagtype namespaceuri=3D"urn:schemas-microsoft-com:office:smarttags" name=3D"City"> <o:smarttagtype namespaceuri=3D"urn:schemas-microsoft-com:office:smarttags" name=3D"country-region"> <!--[if !mso]> <style> st1\:*{behavior:url(#default#ieooui) } </style> <![endif]--> <style> <!-- /* Font Definitions */ @font-face {font-family:SimSun; panose-1:2 1 6 0 3 1 1 1 1 1;} @font-face {font-family:SimSun; panose-1:2 1 6 0 3 1 1 1 1 1;} /* Style Definitions */ p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0cm; margin-bottom:.0001pt; text-align:justify; text-justify:inter-ideograph; font-size:10.5pt; font-family:"Times New Roman";} a:link, span.MsoHyperlink {color:blue; text-decoration:underline;} a:visited, span.MsoHyperlinkFollowed {color:purple; text-decoration:underline;} span.EmailStyle17 {mso-style-type:personal; font-family:Arial; color:windowtext;} span.EmailStyle18 {mso-style-type:personal-reply; font-family:Arial; color:navy;} @page Section1 {size:595.3pt 841.9pt; margin:72.0pt 90.0pt 72.0pt 90.0pt; layout-grid:15.6pt;} div.Section1 {page:Section1;} --> </style><!--[if gte mso 9]><xml> <o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" /> </xml><![endif]--><!--[if gte mso 9]><xml> <o:shapelayout v:ext=3D"edit"> <o:idmap v:ext=3D"edit" data=3D"1" /> </o:shapelayout></xml><![endif]--> <div class=3D"Section1" style=3D"layout-grid:15.6pt"> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">Modified by: <a class=3D"moz-txt-link-abbreviated" href=3D"mailto:= [email protected]">[email protected]</a><o:p></o:p></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">Date: 06/05/2012<o:p></o:p></span></fo= nt></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">Project: RealPlayer for Android Smartphones<o:p></o:p></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">Synopsis: CR: 14965:[swift][simple core]:it always crashed when playing the progressive download audio stream in the second time using the simple core.<o:p></o:p></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t color=3D"navy" face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial; color:navy" lang=3D"EN-US"><o:p>=A0</o:p></span></fon= t></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">Overview:<font color=3D"black"><span style=3D"color:black"> <o:p></o:p></span></font><= /span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t color=3D"black" face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial; color:black" lang=3D"EN-US">The root cause is that there are several objects can not be released, their destructor can not be invoked since their ref counts are not<a moz-do-not-send=3D"true" name=3D"OLE_LINK1"></a><a moz-do-not-send=3D"true" name=3D"OLE_LINK2"></a> equal to zero, which leads to the second time connection can not be established. <o:p><= /o:p></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t color=3D"navy" face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial; color:navy" lang=3D"EN-US"><o:p>=A0</o:p></span></fon= t></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t color=3D"navy" face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial; color:navy" lang=3D"EN-US"><o:p>=A0</o:p></span></fon= t></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">Files Added:<o:p></o:p></span></font><= /p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">N/A<o:p></o:p></span></font></p> <p class=3D"MsoNormal"><font face=3D"Arial" size=3D"1"><spa= n style=3D"font-size: 9.0pt;font-family:Arial" lang=3D"EN-US"><o:p>=A0</o:p= ></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">File Modified:<o:p></o:p></span></font= ></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">client/simplecore/hxflsrc.cpp<o:p></o:= p></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">client/simplecore/hxplay.cpp<o:p></o:p= ></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">client/simplecore/hxrender.cpp<o:p></o= :p></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">client/simplecore/hxstrm.cpp<o:p></o:p= ></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">datatype/ogg/fileformat/ogg_page_reade= r.cpp<o:p></o:p></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">player/kit/android/4.0/PlayerDriver.cp= p<o:p></o:p></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US"><o:p>=A0</o:p></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">Image Size and Heap Use impact (Client -Only):<o:p></o:p></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">None<o:p></o:p></span></font></p> <p class=3D"MsoNormal"><font face=3D"Arial" size=3D"1"><spa= n style=3D"font-size: 9.0pt;font-family:Arial" lang=3D"EN-US"><o:p>=A0</o:p= ></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">Platforms and Profiles Affected:<o:p></o:p></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">Platform: hxclient_3_6_1_atlas<o:p></o:p></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">Profile: helix-client-android-full<o:p></o:p></span></font></p= > <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US"><o:p>=A0</o:p></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">Distribution Libraries Affected:<o:p></o:p></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">None<o:p></o:p></span></font></p> <p class=3D"MsoNormal"><font face=3D"Arial" size=3D"1"><spa= n style=3D"font-size: 9.0pt;font-family:Arial" lang=3D"EN-US"><o:p>=A0</o:p= ></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">Distribution library impact and planned action:<o:p></o:p></span></font></= p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">None<o:p></o:p></span></font></p> <p class=3D"MsoNormal" style=3D"layout-grid-mode:char"><fon= t face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US"><o:p>=A0</o:p></span></font></p> <p class=3D"MsoNormal" style=3D"text-align:left;text-autospace:none" align=3D"le= ft"><font face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">Platforms and Profiles Build Verified:<o:p></o:p></span></font>= </p> <p class=3D"MsoNormal" style=3D"text-align:left;text-autospace:none" align=3D"le= ft"><font face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">Platform: android-4.0-arm-qsd_8x60<o:p></o:p></span></font></p> <p class=3D"MsoNormal" style=3D"text-align:left;text-autospace:none" align=3D"le= ft"><font face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">Profile: helix-client-android-full<o:p></o:p></span></font></p= > <p class=3D"MsoNormal" style=3D"text-align:left;text-autospace:none" align=3D"le= ft"><font face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US"><o:p>=A0</o:p></span></font></p> <p class=3D"MsoNormal" style=3D"text-align:left;text-autospace:none" align=3D"le= ft"><font face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">Platforms and Profiles Functionality verified:<o:p></o:p></span= ></font></p> <p class=3D"MsoNormal" style=3D"text-align:left;text-autospace:none" align=3D"le= ft"><font face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">Platform: android-4.0-arm-qsd_8x60<o:p></o:p></span></font></p> <p class=3D"MsoNormal" style=3D"text-align:left;text-autospace:none" align=3D"le= ft"><font face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US">Profile: helix-client-android-full<o:p></o:p></span></font></p= > <p class=3D"MsoNormal" style=3D"text-align:left;text-autospace:none" align=3D"le= ft"><font face=3D"Arial" size=3D"1"><span style=3D"font-size:9.0pt;font-family:Arial" lang=3D"EN-US"><o:p>=A0</o:p></span></font></p> <p class=3D"MsoNormal"><font face=3D"Arial" size=3D"1"><spa= n style=3D"font-size: 9.0pt;font-family:Arial" lang=3D"EN-US">Branch: 361atlas<o:p></o:p></span></font></p> <p class=3D"MsoNormal"><font face=3D"Arial" size=3D"1"><spa= n style=3D"font-size: 9.0pt;font-family:Arial" lang=3D"EN-US"><o:p>=A0</o:p= ></span></font></p> <p class=3D"MsoNormal"><font face=3D"Arial" size=3D"1"><spa= n style=3D"font-size: 9.0pt;font-family:Arial" lang=3D"EN-US">Copyright assignment: I am a RealNetworks employee.<o:p></o:p><= /span></font></p> <p class=3D"MsoNormal"><font face=3D"Arial" size=3D"1"><spa= n style=3D"font-size: 9.0pt;font-family:Arial" lang=3D"EN-US"><o:p>=A0</o:p= ></span></font></p> <p class=3D"MsoNormal"><font face=3D"Arial" size=3D"1"><spa= n style=3D"font-size: 9.0pt;font-family:Arial" lang=3D"EN-US">Another Comment:<o:p></o:p></span></font></p> <p class=3D"MsoNormal"><font face=3D"Arial" size=3D"1"><spa= n style=3D"font-size: 9.0pt;font-family:Arial" lang=3D"EN-US">In the file: client/simplecore/hxbsrc.cpp, the function: DoCleanup() do nothing, while the function HXSource::Close() release the other objects, I think that we can release this objects through HXSource::DoCleanup(), and we can call the HXSource ::DoCleanup() in the destructor of HXSource, the function HXSource::Close can be replaced by the HXSource::DoCleanup(), I don=92t know whether it is suitable. If it is suitable I will modify this file. Could any experts give me some comments, <o:p></o:p></span></font></p> <p class=3D"MsoNormal"><font face=3D"Arial" size=3D"1"><spa= n style=3D"font-size: 9.0pt;font-family:Arial" lang=3D"EN-US"><o:p>=A0</o:p= ></span></font></p> <p class=3D"MsoNormal"><font face=3D"Arial" size=3D"1"><spa= n style=3D"font-size: 9.0pt;font-family:Arial" lang=3D"EN-US">Best Regards<= o:p></o:p></span></font></p> <p class=3D"MsoNormal"><font face=3D"Arial" size=3D"1"><spa= n style=3D"font-size: 9.0pt;font-family:Arial" lang=3D"EN-US">James Li<o:p>= </o:p></span></font></p> <p class=3D"MsoNormal"><font face=3D"Arial" size=3D"1"><spa= n style=3D"font-size: 9.0pt;font-family:Arial" lang=3D"EN-US"><o:p>=A0</o:p= ></span></font></p> <p class=3D"MsoNormal"><font face=3D"Arial" size=3D"1"><spa= n style=3D"font-size: 9.0pt;font-family:Arial" lang=3D"EN-US">RealNetworks = <st1:country-region w:st=3D"on">China</st1:country-region>, <st1:place w:st=3D"on"><st1:city w:st=3D"on">Beijing<= /st1:city></st1:place> Office<o:p></o:p></span></font></p> <p class=3D"MsoNormal"><font face=3D"Arial" size=3D"1"><spa= n style=3D"font-size: 9.0pt;font-family:Arial" lang=3D"EN-US">Tel: 86-10-59542762<o:p></o:p></span></font></p> <p class=3D"MsoNormal"><font face=3D"Arial" size=3D"1"><spa= n style=3D"font-size: 9.0pt;font-family:Arial" lang=3D"EN-US">Address: 18th Floor,Tower B,Pacific Century Place,2A GongTiBeiLu,Chaoyang District,<st1:place w:st=3D"on">= <st1:city w:st=3D"on">Beijing</st1:city>, <st1:country-regi= on w:st=3D"on">China</st1:country-region></st1:place= > Post Code: 100027<o:p></o:p></span></font></p> <p class=3D"MsoNormal"><font face=3D"Arial" size=3D"1"><spa= n style=3D"font-size: 9.0pt;font-family:Arial" lang=3D"EN-US"><o:p>=A0</o:p= ></span></font></p> </div> </o:smarttagtype></o:smarttagtype></o:smarttagtype></blockquote= > <br> </body> </html> --------------010702000409040100050201-- --===============0846510601== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Helix-client-dev mailing list [email protected] http://lists.helixcommunity.org/mailman/listinfo/helix-client-dev --===============0846510601==--