[Helix-client-dev] CR:change to fix bug 15096:[swift][simple core][streaming]:Crash happens when playing a wma lossless audio file
"James (Jian) Li" <[email protected]> Mon, 25 Jun 2012 19:29:38 -0700
| Newsgroups | gmane.comp.multimedia.helix.devel |
|---|---|
| Message-ID | <[email protected]> |
--===============1385796421== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_2E9F011C3A28314C85D4E538418C4B347B26F124BFSEAMBXcorprea_" --_000_2E9F011C3A28314C85D4E538418C4B347B26F124BFSEAMBXcorprea_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Modified by: [email protected] Date: 06/25/2012 Project: RealPlayer for Android Smartphones Synopsis:CR:change to fix bug 15096:[swift][simple core][streaming]:Crash h= appens when playing a wma lossless audio file Overview: The crash is caused by the mistake of state machine in the asf fileformat. = In the function HXFileSource::Start() of simple core, m_pFFObject->GetFileH= eader() is called, then HXFileSource::FileHeaderReady() will be called by a= sf fileformat and HXFileSource::ProcessFileHeader() will be run, we should = call m_pFFObject->GetStreamHeader() synchronously in HXFileSource::ProcessF= ileHeader(), which will insure that the state machine of asf fileformat is = right, the full core has the same implement. If we call m_pFFObject->GetStr= eamHeader() in HXFileSource::Start(), because it's a asynchronous process, = so it will cause mistake of the state machine of asf fileformat in some cas= es, espacially for the streaming media. Files Added: N/A File Modified: client/simplecore/hxflsrc.cpp Image Size and Heap Use impact (Client -Only): None Platforms and Profiles Affected: Platform: hxclient_3_6_1_atlas Profile: helix-client-android-full Distribution Libraries Affected: None Distribution library impact and planned action: None Platforms and Profiles Build Verified: Platform: android-4.0-arm-qsd_8x60 Profile: helix-client-android-full Platforms and Profiles Functionality verified: Platform: android-4.0-arm-qsd_8x60 Profile: helix-client-android-full Branch: 361atlas Copyright assignment: I am a RealNetworks employee. Best Regards James Li RealNetworks China, Beijing Office Tel: 86-10-59542762 Address: 18th Floor,Tower B,Pacific Century Place,2A GongTiBeiLu,Chaoyang D= istrict,Beijing, China Post Code: 100027 --_000_2E9F011C3A28314C85D4E538418C4B347B26F124BFSEAMBXcorprea_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr= osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns:st1=3D"urn:schemas-microsoft-com:office:smarttags" xmlns=3D"http://ww= w.w3.org/TR/REC-html40"> <head> <meta http-equiv=3DContent-Type content=3D"text/html; charset=3Dus-ascii"> <meta name=3DGenerator content=3D"Microsoft Word 11 (filtered medium)"> <o:SmartTagType namespaceuri=3D"urn:schemas-microsoft-com:office:smarttags" name=3D"place"/> <o:SmartTagType namespaceuri=3D"urn:schemas-microsoft-com:office:smarttags" name=3D"City"/> <o:SmartTagType namespaceuri=3D"urn:schemas-microsoft-com:office:smarttags" name=3D"country-region"/> <!--[if !mso]> <style> st1\:*{behavior:url(#default#ieooui) } </style> <![endif]--> <style> <!--@font-face {体} p.MSONORMAL {体} li.MSONORMAL {体} div.MSONORMAL {体} span.EMAILSTYLE17 {体} /* Font Definitions */ @font-face {font-family:SimSun; panose-1:2 1 6 0 3 1 1 1 1 1;} @font-face {font-family:"&\#23435";} @font-face {font-family:SimSun; panose-1:2 1 6 0 3 1 1 1 1 1;} @font-face {font-family:"\@&\#23435";} /* Style Definitions */ p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0cm; margin-bottom:.0001pt; text-align:justify; text-justify:inter-ideograph; font-size:10.5pt; font-family:"Times New Roman";} a:link, span.MsoHyperlink {color:blue; text-decoration:underline;} a:visited, span.MsoHyperlinkFollowed {color:purple; text-decoration:underline;} span.EmailStyle17 {mso-style-type:personal-compose; font-family:Arial; color:windowtext;} /* Page Definitions */ @page Section1 {size:595.3pt 841.9pt; margin:72.0pt 90.0pt 72.0pt 90.0pt; layout-grid:15.6pt;} div.Section1 {page:Section1;} --> </style> <!--[if gte mso 9]><xml> <o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" /> </xml><![endif]--><!--[if gte mso 9]><xml> <o:shapelayout v:ext=3D"edit"> <o:idmap v:ext=3D"edit" data=3D"1" /> </o:shapelayout></xml><![endif]--> </head> <body lang=3DZH-CN link=3Dblue vlink=3Dpurple style=3D'text-justify-trim:pu= nctuation'> <div class=3DSection1 style=3D'layout-grid:15.6pt'> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Modified by: [email protected]<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Date: 06/25/2012<o= :p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Project: RealPlaye= r for Android Smartphones<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Synopsis:CR:change= to fix bug 15096:[swift][simple core][streaming]</span></font><span lang=3DEN-US>:= </span><font size=3D1 face=3DArial><span lang=3DEN-US style=3D'font-size:9.0pt;font-fami= ly:Arial'>Crash happens when playing a wma lossless audio file<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'><o:p> </o:p><= /span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Overview:<font color=3Dblack><span style=3D'color:black'> <o:p></o:p></span></font></span>= </font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 color= =3Dblack face=3DArial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial; color:black'>The crash is caused by the mistake of state machine in the asf fileformat. In the function HXFileSource::Start() of simple core, m_pFFObject->GetFileHeader() is called, then HXFileSource::FileHeaderRea= dy() will be called by asf fileformat and HXFileSource::ProcessFileHeader() will= be run, we should call m_pFFObject->GetStreamHeader() synchronously in HXFileSource::ProcessFileHeader(), which will insure that the state machine= of asf fileformat is right, the full core has the same implement. If we call m_pFFObject->GetStreamHeader() in HXFileSource::Start(), because it's a asynchronous process, so it will cause mistake of the state machine of asf fileformat in some cases, espacially for the streaming media.<o:p></o:p></s= pan></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 color= =3Dnavy face=3DArial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial; color:navy'><o:p> </o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 color= =3Dnavy face=3DArial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial; color:navy'><o:p> </o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Files Added:<o:p><= /o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>N/A<o:p></o:p></sp= an></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'><o:p> </o:p><= /span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>File Modified:<o:p= ></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>client/simplecore/= hxflsrc.cpp<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'><o:p> </o:p><= /span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Image Size and Hea= p Use impact (Client -Only):<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>None<o:p></o:p></s= pan></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'><o:p> </o:p><= /span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Platforms and Prof= iles Affected:<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Platform: hxclient_3_6_1_atlas<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Profile: helix-client-android-full<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'><o:p> </o:p><= /span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Distribution Libra= ries Affected:<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>None<o:p></o:p></s= pan></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'><o:p> </o:p><= /span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Distribution libra= ry impact and planned action:<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>None<o:p></o:p></s= pan></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'><o:p> </o:p><= /span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Platforms and Prof= iles Build Verified:<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Platform: android-4.0-arm-qsd_8x60<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Profile: helix-client-android-full<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'><o:p> </o:p><= /span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Platforms and Prof= iles Functionality verified:<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Platform: android-4.0-arm-qsd_8x60<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Profile: helix-client-android-full<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'><o:p> </o:p><= /span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Branch: 361atlas<o= :p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'><o:p> </o:p><= /span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Copyright assignme= nt: I am a RealNetworks employee.<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'><o:p> </o:p><= /span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Best Regards<o:p><= /o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>James Li<o:p></o:p= ></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'><o:p> </o:p><= /span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>RealNetworks <st1:= country-region w:st=3D"on">China</st1:country-region>, <st1:place w:st=3D"on"><st1:City w:= st=3D"on">Beijing</st1:City></st1:place> Office<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Tel: 86-10-5954276= 2<o:p></o:p></span></font></p> <p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D1 face=3D= Arial><span lang=3DEN-US style=3D'font-size:9.0pt;font-family:Arial'>Address: 18th Floo= r,Tower B,Pacific Century Place,2A GongTiBeiLu,Chaoyang District,<st1:place w:st=3D= "on"><st1:City w:st=3D"on">Beijing</st1:City>, <st1:country-region w:st=3D"on">China</st1= :country-region></st1:place> Post Code: 100027<o:p></o:p></span></font></p> <p class=3DMsoNormal><font size=3D1 face=3DArial><span lang=3DEN-US style= =3D'font-size: 9.0pt;font-family:Arial'><o:p> </o:p></span></font></p> </div> </body> </html> --_000_2E9F011C3A28314C85D4E538418C4B347B26F124BFSEAMBXcorprea_-- --===============1385796421== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Helix-client-dev mailing list [email protected] http://lists.helixcommunity.org/mailman/listinfo/helix-client-dev --===============1385796421==--