mkclean: update webm codec check
Cyril Marlin <[email protected]> Wed, 24 May 2017 15:26:48 +0000
| Newsgroups | gmane.comp.multimedia.matroska.devel |
|---|---|
| Message-ID | <[email protected]> |
--===============5518076264181297910==
Content-Language: en-US
Content-Type: multipart/alternative;
boundary="_000_482d25e7c5a8420a8b96b66044110c09pdcmailexch02ubisoftorg_"
--_000_482d25e7c5a8420a8b96b66044110c09pdcmailexch02ubisoftorg_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Hello,
Using the v0.8.7 (windows) of mkclean on a webm with vp9 codec the tool fai=
ls with this message :
"Wrong codec 'V_VP9' for profile 'webm' removing track 1"
After looking at the code (mkclean.c line 1229) it seems that webm check co=
decs are V_VP8 & A_VORBIS
Webm allow now 2 more codecs (https://www.webmproject.org/docs/container/) =
: VP9 & OPUS, so I suggest to update this line with:
if (!(TrackType=3D=3DTRACK_TYPE_VIDEO && (tcsisame_ascii(Codec=
ID,T("V_VP8")) || tcsisame_ascii(CodecID, T("V_VP9")))
|| (TrackType=3D=3DTRACK_TYPE_AUDIO && (tcsisame_ascii(Code=
cID,T("A_VORBIS")) || tcsisame_ascii(CodecID, T("A_OPUS"))) )))
Regards,
Cyril Marlin
--_000_482d25e7c5a8420a8b96b66044110c09pdcmailexch02ubisoftorg_
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
<html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr=
osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" =
xmlns:dt=3D"uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:m=3D"http://sc=
hemas.microsoft.com/office/2004/12/omml" xmlns=3D"http://www.w3.org/TR/REC-=
html40">
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
>
<meta name=3D"Generator" content=3D"Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext=3D"edit">
<o:idmap v:ext=3D"edit" data=3D"1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=3D"FR" link=3D"#0563C1" vlink=3D"#954F72">
<div class=3D"WordSection1">
<p class=3D"MsoNormal"><span lang=3D"EN-US">Hello,<o:p></o:p></span></p>
<p class=3D"MsoNormal"><span lang=3D"EN-US">Using the v0.8.7 (windows) of m=
kclean on a webm with vp9 codec the tool fails with this message :<o:p=
></o:p></span></p>
<p class=3D"MsoNormal"><span lang=3D"EN-US">“Wrong codec ‘V_VP9=
’ for profile ‘webm’ removing track 1”<o:p></o:p></=
span></p>
<p class=3D"MsoNormal"><span lang=3D"EN-US"><o:p> </o:p></span></p>
<p class=3D"MsoNormal"><span lang=3D"EN-US">After looking at the code (mkcl=
ean.c line 1229) it seems that webm check codecs are V_VP8 & A_VORBIS<o=
:p></o:p></span></p>
<p class=3D"MsoNormal"><span lang=3D"EN-US"><o:p> </o:p></span></p>
<p class=3D"MsoNormal"><span lang=3D"EN-US">Webm allow now 2 more codecs (<=
a href=3D"https://www.webmproject.org/docs/container/">https://www.webmproj=
ect.org/docs/container/</a>) : VP9 & OPUS, so I suggest to update this =
line with:<o:p></o:p></span></p>
<p class=3D"MsoNormal"><span lang=3D"EN-US"><o:p> </o:p></span></p>
<p class=3D"MsoNormal" style=3D"text-autospace:none"><span lang=3D"EN-US" s=
tyle=3D"font-size:9.5pt;font-family:Consolas;color:black">  =
;
</span><span style=3D"font-size:9.5pt;font-family:Consolas;color:blue">if</=
span><span style=3D"font-size:9.5pt;font-family:Consolas;color:black"> (!(<=
/span><span style=3D"font-size:9.5pt;font-family:Consolas;color:navy">Track=
Type</span><span style=3D"font-size:9.5pt;font-family:Consolas;color:black"=
>=3D=3D</span><span style=3D"font-size:9.5pt;font-family:Consolas;color:#A0=
00A0">TRACK_TYPE_VIDEO</span><span style=3D"font-size:9.5pt;font-family:Con=
solas;color:black">
&& (</span><span style=3D"font-size:9.5pt;font-family:Consolas;col=
or:#880000">tcsisame_ascii</span><span style=3D"font-size:9.5pt;font-family=
:Consolas;color:black">(</span><span style=3D"font-size:9.5pt;font-family:C=
onsolas;color:navy">CodecID</span><span style=3D"font-size:9.5pt;font-famil=
y:Consolas;color:black">,</span><span style=3D"font-size:9.5pt;font-family:=
Consolas;color:#A000A0">T</span><span style=3D"font-size:9.5pt;font-family:=
Consolas;color:black">(</span><span style=3D"font-size:9.5pt;font-family:Co=
nsolas;color:#A31515">"V_VP8"</span><span style=3D"font-size:9.5p=
t;font-family:Consolas;color:black">))
|| </span><span style=3D"font-size:9.5pt;font-family:Consolas;color:#88000=
0">tcsisame_ascii</span><span style=3D"font-size:9.5pt;font-family:Consolas=
;color:black">(</span><span style=3D"font-size:9.5pt;font-family:Consolas;c=
olor:navy">CodecID</span><span style=3D"font-size:9.5pt;font-family:Consola=
s;color:black">,
</span><span style=3D"font-size:9.5pt;font-family:Consolas;color:#A000A0">T=
</span><span style=3D"font-size:9.5pt;font-family:Consolas;color:black">(</=
span><span style=3D"font-size:9.5pt;font-family:Consolas;color:#A31515">&qu=
ot;V_VP9"</span><span style=3D"font-size:9.5pt;font-family:Consolas;co=
lor:black">)))<o:p></o:p></span></p>
<p class=3D"MsoNormal" style=3D"text-autospace:none"><span style=3D"font-si=
ze:9.5pt;font-family:Consolas;color:black"> &n=
bsp; || (</span><span=
style=3D"font-size:9.5pt;font-family:Consolas;color:navy">TrackType</span>=
<span style=3D"font-size:9.5pt;font-family:Consolas;color:black">=3D=3D</sp=
an><span style=3D"font-size:9.5pt;font-family:Consolas;color:#A000A0">TRACK=
_TYPE_AUDIO</span><span style=3D"font-size:9.5pt;font-family:Consolas;color=
:black">
&& (</span><span style=3D"font-size:9.5pt;font-family:Consolas;col=
or:#880000">tcsisame_ascii</span><span style=3D"font-size:9.5pt;font-family=
:Consolas;color:black">(</span><span style=3D"font-size:9.5pt;font-family:C=
onsolas;color:navy">CodecID</span><span style=3D"font-size:9.5pt;font-famil=
y:Consolas;color:black">,</span><span style=3D"font-size:9.5pt;font-family:=
Consolas;color:#A000A0">T</span><span style=3D"font-size:9.5pt;font-family:=
Consolas;color:black">(</span><span style=3D"font-size:9.5pt;font-family:Co=
nsolas;color:#A31515">"A_VORBIS"</span><span style=3D"font-size:9=
.5pt;font-family:Consolas;color:black">))
|| </span><span style=3D"font-size:9.5pt;font-family:Consolas;color:#88000=
0">tcsisame_ascii</span><span style=3D"font-size:9.5pt;font-family:Consolas=
;color:black">(</span><span style=3D"font-size:9.5pt;font-family:Consolas;c=
olor:navy">CodecID</span><span style=3D"font-size:9.5pt;font-family:Consola=
s;color:black">,
</span><span style=3D"font-size:9.5pt;font-family:Consolas;color:#A000A0">T=
</span><span style=3D"font-size:9.5pt;font-family:Consolas;color:black">(</=
span><span style=3D"font-size:9.5pt;font-family:Consolas;color:#A31515">&qu=
ot;A_OPUS"</span><span style=3D"font-size:9.5pt;font-family:Consolas;c=
olor:black">)))
)))<o:p></o:p></span></p>
<p class=3D"MsoNormal"><o:p> </o:p></p>
<p class=3D"MsoNormal">Regards,<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p> </o:p></p>
<p class=3D"MsoNormal">Cyril Marlin<o:p></o:p></p>
</div>
</body>
</html>
--_000_482d25e7c5a8420a8b96b66044110c09pdcmailexch02ubisoftorg_--
--===============5518076264181297910==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
Matroska-devel mailing list
[email protected]
https://lists.matroska.org/cgi-bin/mailman/listinfo/matroska-devel
Read Matroska-Devel on GMane: http://dir.gmane.org/gmane.comp.multimedia.matroska.devel
--===============5518076264181297910==--