Re: about deleting KaxBlockBlob objects

Moritz Bunkus <[email protected]> Wed, 23 Nov 2011 12:05:28 +0100
Newsgroups gmane.comp.multimedia.matroska.user
Message-ID <CANPayMRpFsLY2m-tt_zPMg5tUY+e+nfWyWZRycogOkmuOHLcKA@mail.gmail.com>
Hey,

1. You seem to have reversed the direction in the same; the "source"
file is the directory named "new". The other way around would be
correct.

2. Checking for NULL before "delete pointer;" is not needed. That's in
the C++ standard. The patch for this part of the file doesn't change
the functionality at all.

3. I'm not convinced that your change is actually necessary. I use
libmatroska as it is in mkvmerge including the V2 #defines, and
mkvmerge doesn't have memory leaks that could be traced back to this
part of libmatroska. Please show me a test case.

Kind regards,
mosu
_______________________________________________
Matroska-users mailing list
[email protected]
http://lists.matroska.org/cgi-bin/mailman/listinfo/matroska-users
Read Matroska-Users on GMane: http://dir.gmane.org/gmane.comp.multimedia.matroska.user