Re: mktoolnix v7.9.0 mmg bug

Hello

Here is patch.
Tested on WindowsXP systems(and still works on my 8.1 x64 system).
I can say bootstrapping build environment(and still it is not stable)
took 99% of time. You definitely should consider to make possible to
build project on Windows using native compiler(mingw or VC).

>>>>>> BEGIN PATCH
 src/common/fs_sys_helpers/windows.cpp |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/common/fs_sys_helpers/windows.cpp
b/src/common/fs_sys_helpers/windows.cpp
index 1dfebfd..da0c1bf 100644
--- a/src/common/fs_sys_helpers/windows.cpp
+++ b/src/common/fs_sys_helpers/windows.cpp
@@ -142,10 +142,16 @@ bool
 is_installed() {
   auto sub_key  = "Software\\Microsoft\\Windows\\CurrentVersion\\App
Paths\\mmg.exe";
   auto data_len = DWORD{};
-
-  if (ERROR_SUCCESS != RegGetValueA(HKEY_LOCAL_MACHINE, sub_key,
NULL, RRF_RT_REG_SZ, NULL, NULL, &data_len))
+  DWORD type = REG_SZ;
+  HKEY hSubKey = NULL;
+  if (ERROR_SUCCESS != RegOpenKeyExA(HKEY_LOCAL_MACHINE, sub_key, 0,
KEY_READ, &hSubKey) )
     return false;

+  if (ERROR_SUCCESS != RegQueryValueExA(hSubKey, NULL, NULL, &type,
NULL, &data_len)) {
+    RegCloseKey( hSubKey );
+    return false;
+  }
+  RegCloseKey( hSubKey );
   return data_len > 1;
 }
 >>>>>> END PATCH(It should be usable while transporetd in mail body.
Should I attach it separately?)

2. I do not understand what this code located in common section. Why
check for "mmg.exe" "installation" linked into all other tools? For me
it looks like bad optimization(or its absence on compile/linker
level). ( And I do not understand reasons to do that checks, however
that is not my business).But for now I interested only in WindowsXP
compatibity issue. :)

Regards, Yaroslav

2015-05-11 9:47 GMT+03:00 Moritz Bunkus <[email protected]>:
>
> Hey,
>
> I don't support Windows XP anymore. I haven't supported Windows XP for
> over a year now. That it used to run is accidental.
>
> Not supporting means, for me, not fixing bugs related solely to that
> version. If you're a developer then you can try fixing the issue
> yourself. I'd be happy to include a patch, I just won't invest the time
> myself.
>
> And no, it's not as simple as re-configuring. You'll have to replace
> that call with equivalent code that uses only functions available on
> Windows XP. And you'll have to test it.
>
> Kind regards,
> mosu
>
> _______________________________________________
> Matroska-users mailing list
> [email protected]
> http://lists.matroska.org/cgi-bin/mailman/listinfo/matroska-users
> Read Matroska-Users on GMane: http://dir.gmane.org/gmane.comp.multimedia.matroska.user
>
_______________________________________________
Matroska-users mailing list
[email protected]
http://lists.matroska.org/cgi-bin/mailman/listinfo/matroska-users
Read Matroska-Users on GMane: http://dir.gmane.org/gmane.comp.multimedia.matroska.user