Latest SVN checkin to cpu.c broke MSVC build

Andrew Chew <[email protected]>
Newsgroups gmane.comp.multimedia.ogg.theora.devel
Organization Okashi Studios, Inc.
Message-ID <[email protected]>
Here's the errors that I'm seeing:

Compiling...
cpu.c
..\..\..\lib\cpu.c(93) : error C2414: illegal number of operands
..\..\..\lib\cpu.c(93) : error C2400: inline assembler syntax error in 
'first operand'; found '*'
..\..\..\lib\cpu.c(94) : error C2400: inline assembler syntax error in 
'opcode'; found '*'
..\..\..\lib\cpu.c(94) : warning C4405: 'mov' : identifier is reserved word
..\..\..\lib\cpu.c(124) : warning C4013: 'oc_cpuid_detect_helper' 
undefined; assuming extern returning int

Patch to fix this is attached.  Can someone check it over, though?  I 
really have no clue how the syntax for the different addressing modes in 
assembly look like, so please double-check what I did to those mov 
instructions.

_______________________________________________
theora-dev mailing list
[email protected]
http://lists.xiph.org/mailman/listinfo/theora-dev
cpupatch.patch (text/plain, 461 B)
Index: cpu.c
===================================================================
--- cpu.c	(revision 14814)
+++ cpu.c	(working copy)
@@ -90,8 +90,8 @@
     pushfd
     pop eax
     popfd
-    mov *_eax,eax
-    mov *_ebx,ebx
+    mov [_eax],eax
+    mov [_ebx],ebx
   }
 }
 # endif
@@ -121,7 +121,7 @@
    :"cc"
   );
 #  else
-  oc_cpuid_detect_helper(&eax,&ebx);
+  oc_detect_cpuid_helper(&eax,&ebx);
 #  endif
   /*No cpuid.*/
   if(eax==ebx)return 0;
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.