Re: vorbis-tools 1.3.0 BETA - Help testing.

On Mon, Jan 5, 2009 at 10:04 AM, Michael Gold <[email protected]> wrote:
> On Fri, Jan 02, 2009 at 10:27:28 -0800, Michael Smith wrote:
>> On Thu, Jan 1, 2009 at 8:15 AM, [email protected]
>> <[email protected]> wrote:
>> > Is there any reason why vorbiscomment rebuilds pages from
>> > packets, rather than just copying pages ?
>>
>> Originally I wrote it that way because
>>   1. I'm pretty sure that there are pathological cases you have to do
>> like that, so it was easier to implement only that mode.
>>   2. It also then doubles as a good basic 'ogg vorbis repair' tool
>> (and nothing else existed at the time to do that).
>>
>> Just copying pages where possible would be a good feature though.
>
> Do you remember what the pathological cases were? The only one I can
> think of is when header and non-header data are contained in the same
> page. My patched version can't handle that, but running the file through
> vcut should fix it.

That's the obvious case. It'd probably be acceptable to just return a
failure code in this case (doing the wrong thing wouldn't be ok, of
course).

Also, if the number of header pages changes, you can't _just_ copy the
subsequent pages, you need to renumber and re-checksum them (for which
there was no public API - not sure if that's changed?). That's
fixable, of course.

Mike