Re: Next libvorbis release?

"[email protected]" <[email protected]> Fri, 6 Feb 2009 20:21:14 +0000

Newsgroups	gmane.comp.multimedia.ogg.vorbis.devel
Message-ID	<[email protected]>

This talk prompted me to checkout, and here are a couple of simple
warning patches:

stfu.diff: silence a couple 'unused' warnings - there are others, but
these spam from lots of files.

const.diff: make the tables of I/O functions const, to silence other
unused warnings.

I don't think anyone would *want* to modify them at runtime,
and derf once said making those const was the better thing to do.

_______________________________________________
Vorbis-dev mailing list
[email protected]
http://lists.xiph.org/mailman/listinfo/vorbis-dev

stfu.diff (application/octet-stream, 386 B)

Index: lib/os.h
===================================================================
--- lib/os.h	(revision 15677)
+++ lib/os.h	(working copy)
@@ -156,9 +156,11 @@
 }
 
 static __inline void vorbis_fpu_setround(vorbis_fpu_control *fpu){
+  (void)fpu;
 }
 
 static __inline void vorbis_fpu_restore(vorbis_fpu_control fpu){
+  (void)fpu;
 }
 
 #endif /* Special MSVC x64 implementation */

const.diff (application/octet-stream, 1.5 KB)

Index: include/vorbis/vorbisfile.h
===================================================================
--- include/vorbis/vorbisfile.h	(revision 15677)
+++ include/vorbis/vorbisfile.h	(working copy)
@@ -69,28 +69,28 @@
  * using (the same one as the main application).
  */
 
-static ov_callbacks OV_CALLBACKS_DEFAULT = {
+static const ov_callbacks OV_CALLBACKS_DEFAULT = {
   (size_t (*)(void *, size_t, size_t, void *))  fread,
   (int (*)(void *, ogg_int64_t, int))           _ov_header_fseek_wrap,
   (int (*)(void *))                             fclose,
   (long (*)(void *))                            ftell
 };
 
-static ov_callbacks OV_CALLBACKS_NOCLOSE = {
+static const ov_callbacks OV_CALLBACKS_NOCLOSE = {
   (size_t (*)(void *, size_t, size_t, void *))  fread,
   (int (*)(void *, ogg_int64_t, int))           _ov_header_fseek_wrap,
   (int (*)(void *))                             NULL,
   (long (*)(void *))                            ftell
 };
 
-static ov_callbacks OV_CALLBACKS_STREAMONLY = {
+static const ov_callbacks OV_CALLBACKS_STREAMONLY = {
   (size_t (*)(void *, size_t, size_t, void *))  fread,
   (int (*)(void *, ogg_int64_t, int))           NULL,
   (int (*)(void *))                             fclose,
   (long (*)(void *))                            NULL
 };
 
-static ov_callbacks OV_CALLBACKS_STREAMONLY_NOCLOSE = {
+static const ov_callbacks OV_CALLBACKS_STREAMONLY_NOCLOSE = {
   (size_t (*)(void *, size_t, size_t, void *))  fread,
   (int (*)(void *, ogg_int64_t, int))           NULL,
   (int (*)(void *))                             NULL,