Re: adding directory contents to ogg123 playing in sorted order?
Conrad Parker <[email protected]>
| Newsgroups | gmane.comp.multimedia.ogg.vorbis.devel |
|---|---|
| Message-ID | <[email protected]> |
On 7 March 2010 01:31, Ray Kohler <[email protected]> wrote: > On Mon, Mar 1, 2010 at 10:28 AM, Ray Kohler <[email protected]> wrote: >> >> This turned out to be very easy - I can't remember the last time I >> wrote some code and had it work the first time. Since the relevant >> functions are in libc, the autoconf changes were very easy as well, so >> I did those too. Given that this is a short function, and changes are >> throughout, I judged it more readable to have two complete copies of >> the function, rather than one function with lots of #if defined blocks >> - the preprocessor directives would practically outnumber the code if >> I had done it that way. Patch follows, and is against current SVN >> trunk. (I'm also adding it as an attachment, as I don't trust mail not >> to mangle it.) > > Need anything further from me on this? I've just tested this patch and it seems to work fine. Nice feature :) Committed in changeset 16953 cheers, Conrad.