Re: ogginfo writes errors to stdout
Ray Kohler <[email protected]>
| Newsgroups | gmane.comp.multimedia.ogg.vorbis.devel |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Mar 17, 2010 at 8:22 PM, Conrad Parker <[email protected]> wrote: > On 18 March 2010 04:16, Ray Kohler <[email protected]> wrote: >> The ogginfo tool writes its errors to stdout instead of stderr. >> Shouldn't that change? (Warnings also go to stdout, but that's more of >> a gray area.) The other vorbis-tools don't have this problem, with the >> possible exception of vcut, which writes the usage message to stdout, >> another edge case. > > I think it would make sense for operational errors (eg. file not > found, unreadable etc.) to go to stderr, and surely that's what's > happening with the other vorbis-tools. For conformance errors (ogg > framing, comment format, vorbis headers etc.) it might make sense to > write them to stdout so that they are part of the same output stream > as warnings and general info, ie. so they form a coherent report, and > aren't re-ordered. ogginfo uses its error() function for three cases: - can't open input file - don't know how to handle stream - not an Ogg file so it's a bit of a mixed case.