Re: Tremor maintenance
Stefan Kost <[email protected]>
| Newsgroups | gmane.comp.multimedia.ogg.vorbis.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi, Conrad Parker wrote: > On 20 April 2010 17:16, Stefan Kost <[email protected]> wrote: > >> Conrad Parker wrote: >> >>> On 20 April 2010 15:45, Stefan Kost <[email protected]> wrote: >>> >>> >>>> hi, >>>> >>>> could someone please apply these to Tremor svn? >>>> >>>> 0001-update_symbols.patch >>>> there are 3 public symbols in the headers, which are missing in the >>>> linker script and thus marked as private again. This causes issues for >>>> e.g. gstreamer (https://bugzilla.gnome.org/show_bug.cgi?id=616194). >>>> >>>> 0002-pkgconfig.patch >>>> this adds a pkg config file >>>> >>>> >>>> >>> Hi, >>> >>> I tested and applied these two patches. >>> >>> (Apologies that your attribution didn't stay with the commit -- I set >>> you as the author using git-svn, but subversion turned it into a >>> normal svn commit and rewrote the author info). >>> >>> >> Thanks for your quick action! Here is one more that dists the html docs >> and the win32 build filed as well. >> > > ok, I've applied this to trunk/Tremor. > > I've also merged the relevant parts of these patches into > branches/lowmem-branch/ (without the Win32 bits) > and branches/lowmem-no-byte/ (without the Version_script, doc or Win32 > bits as they don't exist on that branch). > > Conrad. > sorry, the filter script needed more entries, so that ivorbisdec is api compatible with normal vorbisdec. Also attached another patch that fixes the configure: WARNING: unrecognized options: --enable-maintainer-mode at the end of configure run when one was using autogen.sh. If you don't like maintainer mode, then I'd suggest to remove "--enable-maintainer-mode" from the last line in autogen.sh instead. Stefan > >> Once there version thing is resolved >> if would be nice to make a release, then distros can pick it up. >> >> Stefan >> >>>> You probably also want to do something like >>>> Index: configure.in >>>> =================================================================== >>>> --- configure.in (Revision 17148) >>>> +++ configure.in (Arbeitskopie) >>>> @@ -11,7 +11,7 @@ >>>> >>>> AM_CONFIG_HEADER([config.h]) >>>> >>>> -AM_INIT_AUTOMAKE(libvorbisidec,1.2.0) >>>> +AM_INIT_AUTOMAKE(libvorbisidec,1.0.2) >>>> >>>> >>>> to avoid confiusion with the version (see CHANGELOG). There are bugs for >>>> debian/ubuntu regarding this. >>>> >>>> >>> I haven't made this change, i guess it's up to monty. >>> >>> cheers, >>> >>> Conrad. >>> >>> >> _______________________________________________ Vorbis-dev mailing list [email protected] http://lists.xiph.org/mailman/listinfo/vorbis-dev
0004-update_symbols.patch
(text/x-patch, 572 B)
Index: Version_script.in =================================================================== --- Version_script.in (Revision 17155) +++ Version_script.in (Arbeitskopie) @@ -45,7 +45,16 @@ vorbis_comment_clear; vorbis_block_init; vorbis_block_clear; - vorbis_dsp_clear; + vorbis_dsp_clear; + vorbis_synthesis_idheader; + vorbis_synthesis_headerin; + vorbis_synthesis_init; + vorbis_synthesis_restart; + vorbis_synthesis; + vorbis_synthesis_blockin; + vorbis_synthesis_pcmout; + vorbis_synthesis_read; + vorbis_packet_blocksize; local: *;
0005.configure.in-add-maintainer-mode.patch
(text/x-patch, 355 B)
Index: configure.in =================================================================== --- configure.in (Revision 17155) +++ configure.in (Arbeitskopie) @@ -13,6 +13,9 @@ AM_INIT_AUTOMAKE(libvorbisidec,1.2.0) +dnl AM_MAINTAINER_MODE only provides the option to configure to enable it +AM_MAINTAINER_MODE + dnl Library versioning V_LIB_CURRENT=1