vorbis_fpu_setround()

Gábor Kovács <[email protected]> Mon, 7 Nov 2011 09:02:14 +0100

Newsgroups	gmane.comp.multimedia.ogg.vorbis.devel
Message-ID	<CAHLi6csDHLDc+UWqKOk4yD6E=+a-7-sVAoo56evY8tw=piGW9g@mail.gmail.com>

Hi,

I think there is a minor bug in vorbis_fpu_setround().
The "temp" is an output argument instead of input.
Intel compiler warning:

lib/os.h(102): warning #592: variable "temp" is used before its value is set
            "fldcw %1\n\t":"=m"(ret):"m"(temp): "dx");

I would recommend something like:
            "fldcw %1\n\t":"=m"(ret),"=m"(temp): : "dx");

Best regards,
Gábor

_______________________________________________
Vorbis-dev mailing list
[email protected]
http://lists.xiph.org/mailman/listinfo/vorbis-dev