[PATCH] Changes to load/save and add file/dir/URL dialogs.

Hi,

I have never submitted a patch to an open source project before, so if
I have not done something correctly please let me know and I'll be
happy to correct the mistake and resubmit.

First I'll explain why I wrote this patch. I have been developing the
xmms kjofol plugin[1] which provides an alternative interface to
xmms. It does not provide _new_ dialogs for loading/saving playlists or
adding files/dirs/urls to the playlist, instead it attempts to
reproduce the functionality already in xmms, that is it uses standard
gtk dialogs. Currently the functionality of the dialogs in kjofol is
less than those in xmms, and so to improve I could either copy the
code from xmms into kjofol, or extend libxmms to allow the plugin to
control all of the standard xmms dialog boxes. I chose the second
approach.

In order to for the dialog boxes to be controlled from libxmms, and
still to be used from xmms I first had to ensure they were only
created in a single place within the code, so the add dir dialog and
the add url dialog have been remove from main.c and the versions in
playlistwin.c enhanced slightly. Both of these dialogs should really
move into the util.c file now to be with the add file dialog but I was
trying the keep the impact of the patch to a minimum.

Finally libxmms is expanded slightly to allow plugins to control the
dialog boxes.

The only negative impact of the patch is that these dialog boxes are
no longer created as transients for some other window, though if this
is seen as a "very bad thing" then it should be possible to work round
this to some degree.

The patch applied cleanly to CVS xmms on 28 May.

As I said above this is my first ever patch, so I would welcome any
feedback that could be given, and would be happy to make any changes
that are needed to get this into the xmms code.

Thanks

Andrew Burgess

[1] http://www.csse.monash.edu.au/~timf/xmms.html

_______________________________________________
xmms-devel mailing list
[email protected]
http://lists.xmms.org/mailman/listinfo/xmms-devel