Re: patch to append files to playlist

Chris Hellberg wrote:
> --- Morten Nilsen <[email protected]> wrote:
>> > @@ -2415,9 +2420,14 @@
>> >  		break;
>> >  	case MAINWIN_OPT_NPA:
>> >  		cfg.no_playlist_advance =
>>
> GTK_CHECK_MENU_ITEM(gtk_item_factory_get_widget(mainwin_options_menu,
>> "/No Playlist Advance"))->active;
>> > +		break;
>> > +	case MAINWIN_OPT_ATP:
>> > +		cfg.append_to_playlist =
>>
> GTK_CHECK_MENU_ITEM(gtk_item_factory_get_widget(mainwin_options_menu,
>> "/Append to playlist"))->active;
>> > +		cfg.append_to_playlist = TRUE;
>> 
>> I don't know the xmms source, but this seems weird
>> to me..
>> won't setting cfg.append_to_playlist to TRUE
>> explicitly force this option on?
> 
> Yes, you're right, it would. However I figured that it
> would be the least-intrusive as a default option to
> leave it set to FALSE.

what I mean is - won't setting it explicitly to TRUE override the menu
item? Wouldn't the effect of this being, that once enabled, it can not
be disabled again?

-- 
Morten