Re: patch to append files to playlist
Morten Nilsen <[email protected]> Fri, 03 Dec 2004 14:14:11 +0100
| Newsgroups | gmane.comp.multimedia.xmms.devel |
|---|---|
| Message-ID | <[email protected]> |
Cal Peake wrote: > On Fri, 3 Dec 2004, Morten Nilsen wrote: > >> > Don't know what you mean by 'architecture.' >> >> well, IPC between the two instances of xmms > > Sounds like overkill. overkill? xmms allready have IPC.. how else would the command "xmms foo.mp3" tell the already running instance to load foo.mp3? >> I thought cfg.append_to_playlist /was/ the config variable in memory? > > It is, it needs something to update it when the checkbox changes state - > currently nothing does that so xmms doesn't know any different. have you even read the code, or am I totally oblivious to what the GTK_CHECK_MENU_ITEM macro returns? same logic seems to work quite fine for cfg.no_playlist_advance > When you create a checkbox with a graphic toolkit it's just a checkbox, > you check and un-check it all day long but all that happens is it's visual > appearence changes. Some code behind it has to make the check/un-check > change do something. See what I mean? yes, and that is what the cfg.append_to_playlist is there for, right? restarting xmms makes the variable be saved to disk obviously, so the checkbox isn't there just for decoration... -- Morten